← Back to issue list

chore: replace most lifecycle commands with upstream ones

View original Github issue

Metadata

Project
charmcraft
Number
#1538
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 5e3b927c, replacing most lifecycle commands with craft-application upstream commands; pack extension remained outstanding.

Resolution: closed resolved

Reason: PR #1538 was merged as commit 5e3b927c, advancing issue #1532 by replacing most bespoke lifecycle commands with upstream implementations. The remaining work was to extend the upstream pack command.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Work towards #1532 After this we still need to extend the pack command from upstream.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 5e3b927c, replacing most lifecycle commands with craft-application upstream commands; pack extension remained outstanding.
stealth/space-bunny-alpha — closed resolved Merged #1538 (5e3b927c), replacing most lifecycle commands with upstream versions. This advanced #1532, though extending the pack command for it remained outstanding.
qwen/qwen3.6-35b-a3b — — Merged. Replaced most lifecycle commands with upstream versions, removing 297 lines across two files. Approved by three reviewers. Unit tests were not removed since only the pack command had substantial tests, which still requires upstream extension.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Replaced most lifecycle commands with upstream versions to advance issue #1532. Pack remains for future extension. No tests were removed since only pack had substantive tests, aligning with the migration plan.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1532 (confidence 100%)

    PR #1538 explicitly worked toward the broader craft-application lifecycle command migration tracked by #1532.

Related issues

Issue Project State Summary Similarity
#1532 Use craft-application lifecycle commands charmcraft closed Most bespoke lifecycle commands were replaced with craft-application's upstream commands by merged PR #1538 (commit 5e3b927c); pack cleanup followed in #1704 (cfc37020).
82%
#1412 Use upstream craft-application lifecycle commands charmcraft closed Lifecycle migration completed by PR #1538 (5e3b927c); PR #1704 (cfc37020) finished the remaining pack migration cleanup using upstream craft-application commands.
76%
#1356 chore: merge main into craft-application branch charmcraft merged Merged #1356 into the craft-application branch, synchronizing main across 13 files (+82/-74); the broader migration continued in #1399 (3ba803d1).
75%
#2047 chore: remove deprecated craft-application calls charmcraft closed Closed unmerged; its deprecated craft-application API cleanup was superseded by #2360, merged as 5e0dd360 in the broader craft-application 5 upgrade.
75%
#781 chore(merge): 5.2.1 into main craft-application merged Merged release 5.2.1 into main via canonical/craft-application#781 (commit b309794f), including forwarding of managed-instance parallel build settings.
74%
#5644 chore: upgrade to craft-application 5.6 snapcraft merged Merged in commit e2563a1cf: upgraded craft-application to 5.6 and moved core22 architecture detection from the project model to the project service.
73%
#359 Migrate remaining lifecycle commands to craft-application rockcraft closed Resolved by rockcraft PR #395, merged into main; commits e28d53f7 and 0b44fd60 removed legacy lifecycle commands and completed the craft-application migration.
73%
#916 chore: merge 5.10.2 to main craft-application merged Merged craft-application 5.10.2 into main via commit 71051ecb, with all CI checks passing.
73%
#2360 chore: upgrade to craft-application 5 charmcraft merged Merged into main as 5e0dd360, migrating Charmcraft to craft-application 5 for CHARMCRAFT-630.
72%
#1327 chore(deps): update craft-application charmcraft merged Merged charmcraft#1327, updating craft-application across three files (+11/−9) after approval by two reviewers.
72%