← Back to issue list

Use craft-application lifecycle commands

View original Github issue

Metadata

Project
charmcraft
Number
#1532
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Most bespoke lifecycle commands were replaced with craft-application's upstream commands by merged PR #1538 (commit 5e3b927c); pack cleanup followed in #1704 (cfc37020).

Resolution: closed resolved

Reason: Merged PR canonical/charmcraft#1538, commit 5e3b927c, replaced most bespoke lifecycle commands with craft-application upstream implementations. The remaining pack migration cleanup was completed by merged PR #1704, commit cfc37020.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Except for `pack` and possibly `clean` (for backwards compatibility), we don't need to define our own lifecycle commands. The commands we do need to modify for charmcraft should, if possible, use the lifecycle commands' extensible interface. ### Why it needs to get done These commands are cruft and will begin to diverge from other craft applications.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Most bespoke lifecycle commands were replaced with craft-application's upstream commands by merged PR #1538 (commit 5e3b927c); pack cleanup followed in #1704 (cfc37020).
stealth/space-bunny-alpha — closed resolved Most bespoke lifecycle commands were replaced by craft-application's upstream commands in merged PR canonical/charmcraft#1538 (5e3b927c).
stealth/space-bunny-alpha — closed resolved Most bespoke lifecycle commands were replaced with craft-application's upstream commands in merged PR canonical/charmcraft#1538 (commit 5e3b927c).
qwen3.6-35b-a3b-mtp-q6 — — Closed without a documented fix or merge. Likely abandoned or superseded by upstream craft-application updates, as no resolution details were provided in the issue thread.
qwen/qwen3.6-35b-a3b — — Closed and abandoned. The proposal to replace custom lifecycle commands with craft-application equivalents was logged as Jira ticket CRAFT-2512 but never implemented or merged.
qwen/qwen3.6-35b-a3b — — Closed and deferred to internal tracking ticket CRAFT-2512. The task to replace custom lifecycle commands with craft-application equivalents, excluding pack and clean, remains unimplemented.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The proposal to replace custom lifecycle commands with craft-application equivalents was abandoned or deferred, with no resolution or merge details provided.
qwen3.6-35b-a3b-mtp-q6 — — Closed and abandoned on GitHub. An automated bot migrated the request to internal Jira ticket CRAFT-2512. No code changes, merges, or further repository discussion occurred.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#1538 (confidence 100%)

    Merged PR replaced most bespoke lifecycle commands with craft-application's upstream commands.

  • Related To: canonical/charmcraft#1704 (confidence 98%)

    Later merged pack-command migration cleanup completed the remaining work.

Related issues

Issue Project State Summary Similarity
#1412 Use upstream craft-application lifecycle commands charmcraft closed Lifecycle migration completed by PR #1538 (5e3b927c); PR #1704 (cfc37020) finished the remaining pack migration cleanup using upstream craft-application commands.
85%
#1538 chore: replace most lifecycle commands with upstream ones charmcraft merged Merged as commit 5e3b927c, replacing most lifecycle commands with craft-application upstream commands; pack extension remained outstanding.
82%
#359 Migrate remaining lifecycle commands to craft-application rockcraft closed Resolved by rockcraft PR #395, merged into main; commits e28d53f7 and 0b44fd60 removed legacy lifecycle commands and completed the craft-application migration.
79%
#366 Migrate lifecycle commands rockcraft merged Merged lifecycle-command migration in Rockcraft PR #366 (commit e28d53f7), replacing legacy lifecycle commands with craft-application implementations.
77%
#1704 craft-application migration cleanup: pack command charmcraft merged Merged #1704 (commit cfc37020), removing the obsolete craft-application migration pack command missed during earlier cleanup.
76%
#360 Migrate non-lifecycle commands to craft-application rockcraft closed Resolved by merged PR #761 (commit 484099f5), which adopted craft-application’s upstream Init command/service and added --project-dir support.
74%
#4797 refactor: change PackCommand parent snapcraft merged PR #4797 merged as commit b6f464c78, reparenting snapcraft's PackCommand onto craft-application's PackCommand, deleting ~23 lines of duplicated code enabled by craft-application#340/#341.
72%
#1275 feat: use craft-application for pack command charmcraft closed Closed unmerged as superseded after a get_build_plan error. The broader craft-application migration landed in #1538 (5e3b927c), followed by pack-command cleanup in #1704 (cfc37020).
72%