← Back to issue list

style(lint): enable some previously-ignored ruff rules

View original Github issue

Metadata

Project
charmcraft
Number
#1577
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1577 in commit 1b650062, enabling previously ignored Ruff rules and applying related lint/style changes across 10 files.

Resolution: closed resolved

Reason: PR #1577 was merged after approval as commit 1b650062, resolving the Ruff lint configuration and associated style updates.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1577 in commit 1b650062, enabling previously ignored Ruff rules and applying related lint/style changes across 10 files.
stealth/space-bunny-alpha — closed resolved Merged #1577 as commit 1b650062, enabling previously ignored Ruff rules and applying related lint/style changes across 10 files.
qwen/qwen3.6-35b-a3b — — Merged maintainer lengau's changes enabling previously ignored ruff linting rules. Approved by two reviewers, the update modifies ten files (+31/-45 lines) and addresses seven review comments, enforcing stricter code style.
qwen3.6-35b-a3b-mtp-q6 — — Merged a maintainer pull request enabling previously ignored ruff linting rules. Changes were integrated into the main branch without additional discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1825 style(lint): fix ruff 0.6.0 linting errors charmcraft merged Merged PR #1825 as commit 7aa2965b, applying Ruff 0.6.0 autofixes across 31 files to resolve linting errors.
84%
#4981 style(lint): fix ruff 0.6 linting errors snapcraft merged Merged PR #4981 as commit 3a1b8a949, fixing Ruff 0.6 lint errors with a minimal one-file change.
84%
#423 style(lint): fix ruff 0.6.0 linting errors craft-application merged Merged PR #423 as commit 2f56f14b, applying ruff check --fix across 21 files (+70/-70) to clear the new Ruff 0.6.0 lint errors. Approved by 2 maintainer reviewers.
84%
#408 style: fix linting for ruff 0.12 starbase merged Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12.
83%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
82%
#139 style: stricter ruff linters starbase merged PR #139 was merged as commit a48d590, adding stricter Ruff lint rules across six files while retaining 100% test coverage.
82%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed.
82%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.
81%
#357 style: fix lints from ruff 0.12 craft-cli merged Merged as dd635c9, fixing new Ruff 0.12 lint errors across seven files (+11/-10); all CI checks passed.
81%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged PR canonical/craft-application#580 (commit 97347705) by lengau applied style-only fixes (+7/-7, 3 files) for new lint failures caused by a Ruff update; approved by 3 reviewers.
81%