← Back to issue list

style(lint): enable some previously-ignored ruff rules

View original Github issue

Metadata

Project
charmcraft
Number
#1577
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged maintainer lengau's changes enabling previously ignored ruff linting rules. Approved by two reviewers, the update modifies ten files (+31/-45 lines) and addresses seven review comments, enforcing stricter code style.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged maintainer lengau's changes enabling previously ignored ruff linting rules. Approved by two reviewers, the update modifies ten files (+31/-45 lines) and addresses seven review comments, enforcing stricter code style.
qwen3.6-35b-a3b-mtp-q6 Merged a maintainer pull request enabling previously ignored ruff linting rules. Changes were integrated into the main branch without additional discussion.
qwen3.6-35b-a3b-mtp-q6 Merged a maintainer's pull request enabling previously ignored ruff lint rules. The changes were accepted without discussion or revisions, improving project code style consistency.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1662 style(lint): auto-fix with ruff craft-parts merged Merged after two approvals and passing all CI checks. Automatically applies ruff linting fixes across six files, carefully reviewing unsafe changes to update code style without altering functionality.
86%
#55 lint: stricter ruff rules starbase merged Merged stricter ruff linting rules. The change modifies one file with 23 additions and 9 deletions, enforces stricter configuration, and received reviewer approval before integration.
86%
#1825 style(lint): fix ruff 0.6.0 linting errors charmcraft merged Merged following two reviewer approvals and passing CI. The change resolves ruff 0.6.0 linting errors across 31 files using ruff's autofix, resulting in 70 additions and 71 deletions.
85%
#423 style(lint): fix ruff 0.6.0 linting errors craft-application merged Merged after two approvals and passing CI. Resolves ruff 0.6.0 linting errors across 21 files using ruff check --fix, applying automated style corrections to align with the updated linter version.
84%
#139 style: stricter ruff linters starbase merged Merged stricter ruff linter rules across six files (+50/-33 lines). Approved by four reviewers, passed CI checks, and maintained 100% test coverage.
83%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged after approval by three reviewers. Resolves linting errors from a ruff update, modifying three files with a +7/-7 line change. Successfully integrated into the codebase.
82%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Merged after receiving approval from two reviewers and passing all CI checks. The update resolves linting errors introduced by ruff 0.12.0 across five files, adjusting code formatting to comply with the new linter version.
82%
#357 style: fix lints from ruff 0.12 craft-cli merged Merged following approval from three reviewers and successful CI checks. Resolved lint errors introduced by Ruff 0.12 across seven files with minor code adjustments.
81%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged after approval by two reviewers and passing CI. The change updates the codebase to comply with ruff 0.5 linting rules, adjusting style configurations and fixing formatting across one file.
81%
#4981 style(lint): fix ruff 0.6 linting errors snapcraft merged Merged after receiving two approvals and passing CI checks. Resolves ruff 0.6 linting errors with a minimal one-file change.
81%