← Back to issue list

style: stricter ruff linters

View original Github issue

Metadata

Project
starbase
Number
#139
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #139 was merged as commit a48d590, adding stricter Ruff lint rules across six files while retaining 100% test coverage.

Resolution: closed resolved

Reason: The pull request was approved by four reviewers and merged into the repository as commit a48d590. The change updated the Ruff lint configuration and related files to enforce stricter rules.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Please raise any opinions here. If we don't have unanimity on rules we shouldn't include them.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #139 was merged as commit a48d590, adding stricter Ruff lint rules across six files while retaining 100% test coverage.
stealth/space-bunny-alpha — closed resolved Merged stricter Ruff linting rules across six files (+50/-33), approved by four reviewers with 100% test coverage retained; PR #139 landed as a48d590.
qwen/qwen3.6-35b-a3b — — Merged stricter ruff linter rules across six files (+50/-33 lines). Approved by four reviewers, passed CI checks, and maintained 100% test coverage.
qwen3.6-35b-a3b-mtp-q6 — — Successfully merged stricter ruff linter configurations. The changes passed all tests, maintained 100% code coverage, and were integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4981 style(lint): fix ruff 0.6 linting errors snapcraft merged Merged PR #4981 as commit 3a1b8a949, fixing Ruff 0.6 lint errors with a minimal one-file change.
82%
#1577 style(lint): enable some previously-ignored ruff rules charmcraft merged Merged PR #1577 in commit 1b650062, enabling previously ignored Ruff rules and applying related lint/style changes across 10 files.
82%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed.
82%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
82%
#423 style(lint): fix ruff 0.6.0 linting errors craft-application merged Merged PR #423 as commit 2f56f14b, applying ruff check --fix across 21 files (+70/-70) to clear the new Ruff 0.6.0 lint errors. Approved by 2 maintainer reviewers.
81%
#1825 style(lint): fix ruff 0.6.0 linting errors charmcraft merged Merged PR #1825 as commit 7aa2965b, applying Ruff 0.6.0 autofixes across 31 files to resolve linting errors.
81%
#68 lint: update ruff and fix linting craft-archives merged Merged PR #68 as commit 8bb81ae, updating Ruff and fixing lint violations across four files after prerequisite #67.
81%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed.
80%
#1323 style: fix new ruff warnings rockcraft merged PR #1323 merged to main: hand-fixed minor new Ruff warnings in 3 files (+30/-20). Lint and all test suites passed; only source-spread-tests failed (unrelated to style change).
80%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.
80%