← Back to issue list

style: stricter ruff linters

View original Github issue

Metadata

Project
starbase
Number
#139
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged stricter ruff linter rules across six files (+50/-33 lines). Approved by four reviewers, passed CI checks, and maintained 100% test coverage.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Please raise any opinions here. If we don't have unanimity on rules we shouldn't include them.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged stricter ruff linter rules across six files (+50/-33 lines). Approved by four reviewers, passed CI checks, and maintained 100% test coverage.
qwen3.6-35b-a3b-mtp-q6 Successfully merged stricter ruff linter configurations. The changes passed all tests, maintained 100% code coverage, and were integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#55 lint: stricter ruff rules starbase merged Merged stricter ruff linting rules. The change modifies one file with 23 additions and 9 deletions, enforces stricter configuration, and received reviewer approval before integration.
85%
#1323 style: fix new ruff warnings rockcraft merged Merged after approval by two reviewers. Resolves new ruff linting warnings by manually adjusting code across three files. CI checks passed prior to integration.
83%
#1577 style(lint): enable some previously-ignored ruff rules charmcraft merged Merged maintainer lengau's changes enabling previously ignored ruff linting rules. Approved by two reviewers, the update modifies ten files (+31/-45 lines) and addresses seven review comments, enforcing stricter code style.
83%
#4012 linters: migrate to ruff snapcraft merged Migrated linters to Ruff with a legacy-specific ruff.toml. Approved by two reviewers, passed CI with 100% diff coverage, and merged into main with 167 additions and 35 deletions across 20 files.
82%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged after approval by three reviewers. Resolves linting errors from a ruff update, modifying three files with a +7/-7 line change. Successfully integrated into the codebase.
82%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged after approval by two reviewers. Resolves linting failures introduced by ruff 0.12 across 14 files. CI passed for fast tests, linting, and security scans, while slow test failures were tracked separately in #804.
82%
#357 style: fix lints from ruff 0.12 craft-cli merged Merged following approval from three reviewers and successful CI checks. Resolved lint errors introduced by Ruff 0.12 across seven files with minor code adjustments.
81%
#33 lint: fix lint issues with newer ruff craft-archives merged Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket.
81%
#901 style: fix ruff 0.13 linting issues craft-application merged Merged after passing all CI checks and receiving approval from two reviewers. Resolves ruff 0.13 linting issues with a single-line change to one file.
81%
#1825 style(lint): fix ruff 0.6.0 linting errors charmcraft merged Merged following two reviewer approvals and passing CI. The change resolves ruff 0.6.0 linting errors across 31 files using ruff's autofix, resulting in 70 additions and 71 deletions.
81%