← Back to issue list

craft-application migration cleanup: pack command

View original Github issue

Metadata

Project
charmcraft
Number
#1704
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1704 (commit cfc37020), removing the obsolete craft-application migration pack command missed during earlier cleanup.

Resolution: closed resolved

Reason: PR #1704 merged after approval by two reviewers. Commit cfc37020 removes the no-longer-needed comparison pack command and its associated implementation and tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This pack command existed for comparison with the new one, but is no longer necessary. It got missed when I was removing some other no-longer-used commands.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1704 (commit cfc37020), removing the obsolete craft-application migration pack command missed during earlier cleanup.
stealth/space-bunny-alpha — closed resolved Merged cleanup of the craft-application pack command, removing an obsolete migration command missed during earlier cleanup; approved by two reviewers.
qwen/qwen3.6-35b-a3b — — Merged cleanup PR removing an outdated pack command retained for comparison during the craft-application migration. Approved by two reviewers with passing CI, the change deletes 1309 lines across six files.
qwen3.6-35b-a3b-mtp-q6 — — Merged a cleanup PR that removed an obsolete pack command left over during the craft-application migration. The command was retained for comparison but became unnecessary after the new implementation was finalized.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1275 feat: use craft-application for pack command charmcraft closed Closed unmerged as superseded after a get_build_plan error. The broader craft-application migration landed in #1538 (5e3b927c), followed by pack-command cleanup in #1704 (cfc37020).
81%
#1412 Use upstream craft-application lifecycle commands charmcraft closed Lifecycle migration completed by PR #1538 (5e3b927c); PR #1704 (cfc37020) finished the remaining pack migration cleanup using upstream craft-application commands.
77%
#1532 Use craft-application lifecycle commands charmcraft closed Most bespoke lifecycle commands were replaced with craft-application's upstream commands by merged PR #1538 (commit 5e3b927c); pack cleanup followed in #1704 (cfc37020).
76%
#4797 refactor: change PackCommand parent snapcraft merged PR #4797 merged as commit b6f464c78, reparenting snapcraft's PackCommand onto craft-application's PackCommand, deleting ~23 lines of duplicated code enabled by craft-application#340/#341.
74%
#4468 feature/craft-application: migrate version command snapcraft closed Version command migration to craft-application landed in merged PR #4614 (commit 885106d06), completing the work drafted in 24d48da8 and closing the tracking issue ahead of the craft-application rebase.
72%
#4614 feat(craft-application): migrate version command snapcraft merged Merged PR #4614 (commit 885106d06) migrated Snapcraft's version command to craft-application, resolving #4468; legacy version handling remained out of scope.
71%
#1538 chore: replace most lifecycle commands with upstream ones charmcraft merged Merged as commit 5e3b927c, replacing most lifecycle commands with craft-application upstream commands; pack extension remained outstanding.
70%