← Back to issue list

craft-application migration cleanup: pack command

View original Github issue

Metadata

Project
charmcraft
Number
#1704
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged cleanup PR removing an outdated pack command retained for comparison during the craft-application migration. Approved by two reviewers with passing CI, the change deletes 1309 lines across six files.

Suggested action:

No scores available.

Issue body

This pack command existed for comparison with the new one, but is no longer necessary. It got missed when I was removing some other no-longer-used commands.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged cleanup PR removing an outdated pack command retained for comparison during the craft-application migration. Approved by two reviewers with passing CI, the change deletes 1309 lines across six files.
qwen3.6-35b-a3b-mtp-q6 Merged a cleanup PR that removed an obsolete pack command left over during the craft-application migration. The command was retained for comparison but became unnecessary after the new implementation was finalized.
qwen3.6-35b-a3b-mtp-q6 Merged cleanup removing the obsolete comparison pack command from the craft-application migration. The command was retained for testing but became unnecessary and was finally deleted.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#354 refactor: use craft-application for "pack" rockcraft merged Merged a refactor routing rockcraft pack to the new craft-application-based runner, resolving issue #316. The update spans 24 files with 935 additions and 40 deletions, received two approvals, and passed CI checks.
74%
#1571 refactor: remove unused clean command implementation charmcraft merged Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files.
74%
#1420 fix: use craft-application clean command charmcraft closed Closed pull request implementing a fix to use the craft-application clean command. The change modifies five files, removing 300 lines and adding 10. No review comments or CI checks were recorded. The PR was closed without explicit merge status.
74%
#2 craft-application specification craft-application merged Merged the craft-application specification update by maintainer lengau. The change modified eight files, removing 108 lines and adding 22. No formal review or CI checks were recorded prior to merge.
73%
#4614 feat(craft-application): migrate version command snapcraft merged Merged, resolving issue #4468. The version command was migrated to craft-application across seven files. Approved by two reviewers and integrated despite minor Codecov coverage warnings.
73%
#1358 feat(craft-application): migrate store commands charmcraft merged Migrated store commands in craft-application. Approved by three reviewers and merged, modifying 29 files with 2859 additions and 344 deletions.
73%
#1275 feat: use craft-application for pack command charmcraft closed Superseded by the author. The feature to use craft-application for the pack command was closed after initial approval, unresolved review comments, and an internal error were reported.
72%
#1520 refactor: remove old "init" command implementation charmcraft merged Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248.
72%
#739 Hide the 'build' command and make 'pack' the common one (CRAFT-938). charmcraft merged Merged after approval, this change hides the 'build' command and promotes 'pack' as the common command, resolving #720. The update modifies four files with four additions and three deletions.
72%
#133 fix(build): only package craft-application/* craft-application merged Merged a build fix restricting packaging to craft-application/* directories to match Starbase. Approved by three reviewers, passed CI, and caused no coverage change. The single-file update added two and removed six lines.
72%