← Back to issue list

feat: use craft-application for pack command

View original Github issue

Metadata

Project
charmcraft
Number
#1275
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged as superseded after a get_build_plan error. The broader craft-application migration landed in #1538 (5e3b927c), followed by pack-command cleanup in #1704 (cfc37020).

Resolution: closed superseded

Reason: Maintainer @lengau explicitly marked #1275 as superseded after a reported CharmcraftConfig.get_build_plan AttributeError. PR #1538 replaced the lifecycle commands through commit 5e3b927c, and #1704 later completed the pack-command cleanup in cfc37020.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded after a get_build_plan error. The broader craft-application migration landed in #1538 (5e3b927c), followed by pack-command cleanup in #1704 (cfc37020).
stealth/space-bunny-alpha — closed superseded PR #1275 to use craft-application for pack was closed unmerged by @lengau as superseded after a get_build_plan internal error; migration completed later in #1538 (5e3b927c) and #1704 (cfc37020).
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded after a get_build_plan internal error. The upstream lifecycle migration followed in #1538 (5e3b927c), with pack-command cleanup in #1704 (cfc37020).
qwen/qwen3.6-35b-a3b — — Superseded by the author. The feature to use craft-application for the pack command was closed after initial approval, unresolved review comments, and an internal error were reported.
qwen3.6-35b-a3b-mtp-q6 — — Integrating craft-application for the pack command was superseded by the author after triggering a charmcraft AttributeError. The request was closed without merging.

Update history

No update history recorded yet.

Related work

  • Superseded By: charmcraft#1538 (confidence 96%)

    Merged broader craft-application lifecycle migration in commit 5e3b927c.

  • Related To: charmcraft#1704 (confidence 94%)

    Merged pack-command migration cleanup in commit cfc37020.

Related issues

Issue Project State Summary Similarity
#1704 craft-application migration cleanup: pack command charmcraft merged Merged #1704 (commit cfc37020), removing the obsolete craft-application migration pack command missed during earlier cleanup.
81%
#1606 build(deps): use craft-application 2.0.0 charmcraft closed Closed unmerged as superseded; the same craft-application 2.0.0 update was merged via #1596 in commit 212b2005.
75%
#4444 feat: initial craft-application work snapcraft closed Closed unmerged after prolonged inactivity; initial craft-application support later landed via merged PR #4560 at commit 98550856e.
74%
#354 refactor: use craft-application for "pack" rockcraft merged Merged #354 routed rockcraft pack through the CraftApplication runner (commit 8d74e452); its feature branch was later integrated into main by #395.
72%
#4468 feature/craft-application: migrate version command snapcraft closed Version command migration to craft-application landed in merged PR #4614 (commit 885106d06), completing the work drafted in 24d48da8 and closing the tracking issue ahead of the craft-application rebase.
72%
#4565 feat: implement core24 "pack" command snapcraft merged Rebase-merged PR #4565 (commit e75d0e93b) on feature/craft-application: implemented the core24 "pack" command (Package service) plus "clean", re-enabled their spread tests and updated expected errors. Closes #4470.
72%
#5612 feat: only create packages if necessary snapcraft closed Closed unmerged; conditional repacking was moved behind opt-in support in canonical/craft-application#829 and deferred until ST160.
72%
#1532 Use craft-application lifecycle commands charmcraft closed Most bespoke lifecycle commands were replaced with craft-application's upstream commands by merged PR #1538 (commit 5e3b927c); pack cleanup followed in #1704 (cfc37020).
72%
#4614 feat(craft-application): migrate version command snapcraft merged Merged PR #4614 (commit 885106d06) migrated Snapcraft's version command to craft-application, resolving #4468; legacy version handling remained out of scope.
72%
#4653 feat(craft-application): support remote build snapcraft closed Closed unmerged; superseded by canonical/snapcraft#4664 (commit 57d184af7), which landed the same craft-application remote build support for core24.
71%