fix(charm_builder): bump minimum pip version to 23
Metadata
Current evaluation
Merged #1437 in commit fe263387, raising charm_builder's minimum pip to 23 so strict dependencies use the prebuilt wheel cache; released in Charmcraft 2.5.4.
Resolution: closed resolved
Reason: PR #1437 was approved and merged, closing #1374. Commit fe263387 implemented the pip 23 minimum and shipped in Charmcraft 2.5.4.
Evaluated by: mr-cal-bot
No scores available.
Issue body
fixes #1374
Pip 22 doesn't use the prebuilt wheel cache when using `--no-binary=[list of packages]`, but does when using `--no-binary=:all:`. As such, using strict dependencies won't use the cache with pip 22
Has potential regressions, so I'm going to run a large spread on this: https://github.com/canonical/charmcraft/actions/runs/7184537100
EDIT: Large spread failures are unrelated and are fixed in https://github.com/canonical/charmcraft/pull/1438. This should be cherry-picked to the 2.5 branch.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1437 in commit fe263387, raising charm_builder's minimum pip to 23 so strict dependencies use the prebuilt wheel cache; released in Charmcraft 2.5.4. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1437 (fe263387), raising charm_builder's minimum pip to 23 so strict dependencies use the wheel cache. Fixes #1374 and shipped in charmcraft 2.5.4. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1437 as fe263387, raising charm_builder’s minimum pip version to 23 and fixing #1374’s ignored wheel cache. The fix shipped in Charmcraft 2.5.4. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1437 (fe263387), raising charm_builder’s minimum pip from 22 to 23 so strict dependencies correctly use the prebuilt wheel cache; released in Charmcraft 2.5.4. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update bumping the minimum pip version to 23, resolving wheel cache issues with strict dependency flags. Approved by two reviewers, passed CI, and recommended for cherry-picking to the 2.5 branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to bump the minimum pip version to 23, fixing wheel cache behavior with --no-binary. The change passed regression testing and was recommended for cherry-picking to the 2.5 branch. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/charmcraft#1374
(confidence 100%)
Reported the ignored pip wheel cache and was fixed by this merged change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1716 feat: upgrade minimum pip version | charmcraft | merged | Merged in canonical/charmcraft#1716 (def89c50), raising Charmcraft's minimum required pip version; the update was backported to 2.x by #1723 (5e119c36). | |
| #1891 fix(charm_builder): force-install pip | charmcraft | merged | Merged 2.x hotfix #1891 (df6a92c9) to force-reinstall pip when needed; released in Charmcraft 2.7.3. | |
| #1892 fix(charm_builder): force-install pip | charmcraft | merged | Merged PR #1892 (358657b6) added a Charmcraft 3.x hotfix to force-upgrade an insufficient pip in existing venvs, fixing #1456. | |
| #1456 Strict dependencies prevents charm from building | charmcraft | closed | Fixed in PR #1716 (commit def89c50): Charmcraft raised its minimum pip version so strict-dependency builds upgrade old virtual environments first. | |
| #1374 pip wheel cache ignored | charmcraft | closed | Pip 23 restored use of Charmcraft's shared wheel cache. The fix merged in canonical/charmcraft#1437 (fe263387), was backported by #1723, and shipped in Charmcraft 2.5.4. | |
| #2247 The charm build failed due to the recent release of wheel version 0.46.1. | charmcraft | open | Wheel 0.46.1 broke Charmcraft source-dependency charm builds with a missing bdist_wheel command; pinning 0.45.1 works, but the issue remains untriaged. |