← Back to issue list

fix(charm_builder): bump minimum pip version to 23

View original Github issue

Metadata

Project
charmcraft
Number
#1437
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged update bumping the minimum pip version to 23, resolving wheel cache issues with strict dependency flags. Approved by two reviewers, passed CI, and recommended for cherry-picking to the 2.5 branch.

Suggested action:

No scores available.

Issue body

fixes #1374 Pip 22 doesn't use the prebuilt wheel cache when using `--no-binary=[list of packages]`, but does when using `--no-binary=:all:`. As such, using strict dependencies won't use the cache with pip 22 Has potential regressions, so I'm going to run a large spread on this: https://github.com/canonical/charmcraft/actions/runs/7184537100 EDIT: Large spread failures are unrelated and are fixed in https://github.com/canonical/charmcraft/pull/1438. This should be cherry-picked to the 2.5 branch.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged update bumping the minimum pip version to 23, resolving wheel cache issues with strict dependency flags. Approved by two reviewers, passed CI, and recommended for cherry-picking to the 2.5 branch.
qwen3.6-35b-a3b-mtp-q6 Merged to bump the minimum pip version to 23, fixing wheel cache behavior with --no-binary. The change passed regression testing and was recommended for cherry-picking to the 2.5 branch.
qwen3.6-35b-a3b-mtp-q6 Merged PR bumping minimum pip to 23 to fix a wheel cache bug with --no-binary breaking strict dependency caching. Resolves #1374. Author requested cherry-pick to 2.5 after unrelated CI failures were fixed separately.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1892 fix(charm_builder): force-install pip charmcraft merged Merged hotfix forcing pip installation in the virtual environment when previously skipped. Resolves #1456 for the 3.x branch. Approved by two reviewers and passed CI checks.
76%
#1891 fix(charm_builder): force-install pip charmcraft merged Merged hotfix for 2.x forcing pip installation in the charm_builder venv, resolving #1456. Approved by two reviewers, passed CI, and merged successfully.
75%
#1374 pip wheel cache ignored charmcraft closed Fixed in charmcraft 2.5.4 by updating pip to version 23+, resolving the wheel cache issue caused by pip 22's --no-binary handling. Verified by the reporter and closed.
71%