← Back to issue list

fix(charm_builder): force-install pip

View original Github issue

Metadata

Project
charmcraft
Number
#1892
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged hotfix forcing pip installation in the virtual environment when previously skipped. Resolves #1456 for the 3.x branch. Approved by two reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

The previous version wasn't installing pip if it was already in the venv. This is the hotfix for 3.x, while https://github.com/canonical/charmcraft/pull/1891 is the hotfix for 2.x. Fixes #1456 CRAFT-2538

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged hotfix forcing pip installation in the virtual environment when previously skipped. Resolves #1456 for the 3.x branch. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged a hotfix that forces pip installation in virtual environments when the existing version is below the required minimum. Resolves #1456 and CRAFT-2538 by conditionally upgrading pip after verifying the current version.
qwen3.6-35b-a3b-mtp-q6 Merged a hotfix for v3.x that forces pip installation in the virtual environment when the existing version lacks required features. Includes a pre-check to skip unnecessary upgrades, resolving issue #1456.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1891 fix(charm_builder): force-install pip charmcraft merged Merged hotfix for 2.x forcing pip installation in the charm_builder venv, resolving #1456. Approved by two reviewers, passed CI, and merged successfully.
94%
#1437 fix(charm_builder): bump minimum pip version to 23 charmcraft merged Merged update bumping the minimum pip version to 23, resolving wheel cache issues with strict dependency flags. Approved by two reviewers, passed CI, and recommended for cherry-picking to the 2.5 branch.
76%
#1794 fix(strict-deps): cherry-pick #1784 into 3.1 hotfix branch charmcraft merged Merged cherry-pick of #1784 into the 3.1 hotfix branch. Adds pip check to validate charm virtualenv dependencies, failing the build if requirements are unmet. Resolves #1781. Approved by two reviewers with passing CI checks.
74%
#10 Fix pip installation charmcraft merged Merged a fix for pip installation by using setuptools to include the charmcraft.commands module and correcting the entrypoint to reference the main function. Approved by reviewers and passed CI checks.
70%