← Back to issue list

fix(charm_builder): force-install pip

View original Github issue

Metadata

Project
charmcraft
Number
#1892
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1892 (358657b6) added a Charmcraft 3.x hotfix to force-upgrade an insufficient pip in existing venvs, fixing #1456.

Resolution: closed resolved

Reason: PR #1892 was merged as commit 358657b6. It fixes #1456 by upgrading pip when the venv version lacks required feature support; PR #1891 delivered the equivalent 2.x hotfix.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The previous version wasn't installing pip if it was already in the venv. This is the hotfix for 3.x, while https://github.com/canonical/charmcraft/pull/1891 is the hotfix for 2.x. Fixes #1456 CRAFT-2538

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1892 (358657b6) added a Charmcraft 3.x hotfix to force-upgrade an insufficient pip in existing venvs, fixing #1456.
stealth/space-bunny-alpha — closed resolved Merged 3.x hotfix #1892 (358657b6) to force-install supported pip when the venv already has pip, fixing #1456; #1891 applied the 2.x counterpart.
stealth/space-bunny-alpha — closed resolved Merged the 3.x hotfix ensuring charm_builder installs a sufficiently new pip even when pip is already present, fixing #1456; commit 358657b6.
qwen/qwen3.6-35b-a3b — — Merged hotfix forcing pip installation in the virtual environment when previously skipped. Resolves #1456 for the 3.x branch. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a hotfix that forces pip installation in virtual environments when the existing version is below the required minimum. Resolves #1456 and CRAFT-2538 by conditionally upgrading pip after verifying the current version.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#1891 fix(charm_builder): force-install pip charmcraft merged Merged 2.x hotfix #1891 (df6a92c9) to force-reinstall pip when needed; released in Charmcraft 2.7.3.
92%
#1437 fix(charm_builder): bump minimum pip version to 23 charmcraft merged Merged #1437 in commit fe263387, raising charm_builder's minimum pip to 23 so strict dependencies use the prebuilt wheel cache; released in Charmcraft 2.5.4.
77%
#1716 feat: upgrade minimum pip version charmcraft merged Merged in canonical/charmcraft#1716 (def89c50), raising Charmcraft's minimum required pip version; the update was backported to 2.x by #1723 (5e119c36).
74%
#1456 Strict dependencies prevents charm from building charmcraft closed Fixed in PR #1716 (commit def89c50): Charmcraft raised its minimum pip version so strict-dependency builds upgrade old virtual environments first.
72%