← Back to issue list

feat(reactive): run charm build in verbose mode

View original Github issue

Metadata

Project
charmcraft
Number
#2021
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2021 (commit 7129d57e): the reactive plugin now auto-appends --verbose to `charm build` unless the user set a log level, fixing #924.

Resolution: closed resolved

Reason: The PR was merged into main with 2 approving reviewers and no unresolved comments, adding a default `--verbose` to the reactive plugin's charm build invocation. It states "Fixes #924", and issue #924 was subsequently closed as fixed by this commit.

Evaluated by: mr-cal-bot

No scores available.

Issue body

While a user could previously have added `--verbose` to `reactive-charm-build-arguments`, this automatically adds `--verbose` if the user hasn't specified a log level. The verbose text gets handled by craft-cli anyway, but this changes the default so the text gets added to the log. Spread test failures are unrelated: https://github.com/canonical/charmcraft/issues/2023 Fixes #924

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2021 (commit 7129d57e): the reactive plugin now auto-appends --verbose to `charm build` unless the user set a log level, fixing #924.
stealth/space-bunny-alpha — closed resolved Merged PR #2021 (7129d57e), making the reactive plugin pass --verbose to charm build when no log level is specified and fixing #924.
stealth/space-bunny-alpha — closed resolved Merged #2021 (commit 7129d57e), adding --verbose to reactive charm build arguments when no log level is set, so verbose output is captured. Fixes #924.
qwen/qwen3.6-35b-a3b — — Merged after two approvals and passing CI. Automatically adds the --verbose flag to charm build arguments when no log level is specified, ensuring verbose output is captured in logs. Resolves issue #924.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes automatically append --verbose to charm build arguments when no log level is specified, ensuring verbose output is captured in logs. Resolves #924.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#924 (confidence 95%)

    The PR body declares "Fixes #924"; that issue ("reactive plugin: call `charm build` with `-v`") is now closed as fixed by PR #2021.

  • Related To: canonical/charmcraft#2023 (confidence 90%)

    Cited in the PR as an unrelated cause of spread test failures during the change; separately fixed by PR #2043 (libffi-dev build package).

Related issues

Issue Project State Summary Similarity
#924 reactive plugin: call `charm build` with `-v` charmcraft closed Fixed by merged PR #2021 (commit 7129d57e): the reactive plugin adds --verbose to charm build unless an explicit verbosity or log level is supplied.
91%
#863 reactive_plugin: Support arguments to charm build command charmcraft merged Merged in charmcraft PR #863 via commit a5f200b1, adding reactive-charm-build-arguments so the reactive plugin can pass options to charm build; fixes #809.
75%
#613 plugins: reactive using charm tool (CRAFT-699) charmcraft merged Merged PR #613 (merge commit 32c8650a, branch charm-tools-plugin) added the reactive charm plugin built on the charm tool, implementing CRAFT-699; 11 files, +499/-8.
71%
#809 Reactive plugin doesn't allow for other `charm` cli arguments. charmcraft closed Resolved by merged PR #863 (merge commit a5f200b1): reactive builds can now pass charm build options such as --layer-index via reactive-charm-build-arguments.
71%