← Back to issue list

Reactive plugin doesn't allow for other `charm` cli arguments.

View original Github issue

Metadata

Project
charmcraft
Number
#809
Type
issue
State
closed
Author
addyess
Labels
—
Created
Updated
Closed

Current evaluation

Resolved by merged PR #863 (merge commit a5f200b1): reactive builds can now pass charm build options such as --layer-index via reactive-charm-build-arguments.

Resolution: closed resolved

Reason: PR #863 was merged to resolve #809, with commit 873697f7 adding support for passing arguments to the charm build command and configuration through reactive-charm-build-arguments.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The `charm-tools` builder `charm` allows for many build switches, some which are necessary to produce reproducible stable builds. It doesn't seem that this plugin allows for any such options to be specified. For instance, one cannot override the `layer-index` used during the build with this cli switch, so only the default is available. ```bash -i LAYER_INDEX, --layer-index LAYER_INDEX One or more index URLs used to look up layers, separated by commas. Can include the token DEFAULT, which will be replaced by the default index (https://juju.github.io/layer-index/). E.g.: https://my-site.com/index/,DEFAULT ``` https://github.com/canonical/charmcraft/blob/a2205cb1270220c03d244814468ea812e984c01c/charmcraft/reactive_plugin.py#L159-L165 it would be beneficial to reactive charms for `charmcraft` to build with these switches primarily as CLI switches or at a minimum `charmcraft.yaml` configuration options.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Resolved by merged PR #863 (merge commit a5f200b1): reactive builds can now pass charm build options such as --layer-index via reactive-charm-build-arguments.
stealth/space-bunny-alpha — closed resolved Feature request closed by merged PR #863 (commit a5f200b1): the reactive plugin gained a reactive-charm-build-arguments option to pass extra flags (e.g. --layer-index) to the underlying charm build command.
stealth/space-bunny-alpha — closed resolved Resolved by merged PR #863 (commit a5f200b1), adding reactive-charm-build-arguments to pass options such as --layer-index to charm build.
qwen3.6-35b-a3b-mtp-q6 — — Closed without resolution. The reactive plugin could not pass custom charm CLI arguments like --layer-index. Despite user requests for reproducible builds and binary wheel support, the feature was abandoned due to inactivity.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The feature request to pass additional charm CLI arguments to the reactive plugin was abandoned, with no fix merged or configuration added.
qwen3.6-35b-a3b-mtp-q6 — — Closed without implementation. The reactive plugin limitation preventing custom charm CLI arguments like --layer-index remains unresolved. No fix or alternative solution was provided, indicating the request was abandoned.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#863 (confidence 100%)

    Merged PR #863 directly fixes #809; its implementation commit was 873697f7 and the merge commit was a5f200b1.

Related issues

Issue Project State Summary Similarity
#863 reactive_plugin: Support arguments to charm build command charmcraft merged Merged in charmcraft PR #863 via commit a5f200b1, adding reactive-charm-build-arguments so the reactive plugin can pass options to charm build; fixes #809.
84%
#924 reactive plugin: call `charm build` with `-v` charmcraft closed Fixed by merged PR #2021 (commit 7129d57e): the reactive plugin adds --verbose to charm build unless an explicit verbosity or log level is supplied.
75%
#1816 Reactive charm built with charmcraft 3.x is missing options from the included layers and is broken charmcraft open Reactive layer options were lost because Charmcraft 3.x overwrote charm-tools' config.yaml; commit aa28f0dc and PR #2245 now preserve the generated configuration.
74%
#610 many: add reactive charm plugin charmcraft closed PR #610 (charm-tools-based reactive plugin) was closed unmerged on 2021-12-14 by sergiusens in favor of #613, which reimplemented the plugin on the charm tool (CRAFT-699) and merged as 32c8650a.
74%
#2194 Builds of charm using reactive plugin produces different config option charmcraft closed Fixed by merged PR #2245 (commit aa28f0dc): reactive-generated config.yaml is no longer overwritten, preserving options such as snapd_refresh.
72%
#613 plugins: reactive using charm tool (CRAFT-699) charmcraft merged Merged PR #613 (merge commit 32c8650a, branch charm-tools-plugin) added the reactive charm plugin built on the charm tool, implementing CRAFT-699; 11 files, +499/-8.
72%
#2021 feat(reactive): run charm build in verbose mode charmcraft merged Merged PR #2021 (commit 7129d57e): the reactive plugin now auto-appends --verbose to `charm build` unless the user set a log level, fixing #924.
71%