reactive_plugin: Support arguments to charm build command
Metadata
Current evaluation
Merged in charmcraft PR #863 via commit a5f200b1, adding reactive-charm-build-arguments so the reactive plugin can pass options to charm build; fixes #809.
Resolution: closed resolved
Reason: PR #863 was merged into main as commit a5f200b1. It added support for forwarding configured arguments to charm build, resolving issue #809.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This patch adds the ability to pass arguments to the `charm build` command when using the reactive plugin.
Example charmcraft.yaml:
```yaml
type: charm
parts:
charm:
plugin: reactive
reactive-charm-build-arguments:
- --binary-wheels-from-source
build-packages:
- tox
- git
- python3-dev
- libffi-dev
source: src/
build-snaps:
- charm/latest/edge
build-environment:
- CHARM_INTERFACES_DIR: $CRAFT_PROJECT_DIR/interfaces/
- CHARM_LAYERS_DIR: $CRAFT_PROJECT_DIR/layers/
```
Fixes: #809
Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in charmcraft PR #863 via commit a5f200b1, adding reactive-charm-build-arguments so the reactive plugin can pass options to charm build; fixes #809. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into main via commit a5f200b1 in PR #863, adding reactive-charm-build-arguments to pass flags to `charm build`; fixes #809. | |
| qwen/qwen3.6-35b-a3b | — | — | Added reactive-charm-build-arguments to pass custom flags to the charm build command. Merged after approval and passing CI, resolving issue #809. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds reactive-charm-build-arguments config to pass custom flags to charm build. Resolves #809. Documentation updates are pending. |
Update history
No update history recorded yet.
Related work
-
Related To:
charmcraft#809
(confidence 100%)
PR #863 explicitly fixes #809, whose closure record identifies this PR and commit as its resolution.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #809 Reactive plugin doesn't allow for other `charm` cli arguments. | charmcraft | closed | Resolved by merged PR #863 (merge commit a5f200b1): reactive builds can now pass charm build options such as --layer-index via reactive-charm-build-arguments. | |
| #924 reactive plugin: call `charm build` with `-v` | charmcraft | closed | Fixed by merged PR #2021 (commit 7129d57e): the reactive plugin adds --verbose to charm build unless an explicit verbosity or log level is supplied. | |
| #2021 feat(reactive): run charm build in verbose mode | charmcraft | merged | Merged PR #2021 (commit 7129d57e): the reactive plugin now auto-appends --verbose to `charm build` unless the user set a log level, fixing #924. | |
| #613 plugins: reactive using charm tool (CRAFT-699) | charmcraft | merged | Merged PR #613 (merge commit 32c8650a, branch charm-tools-plugin) added the reactive charm plugin built on the charm tool, implementing CRAFT-699; 11 files, +499/-8. | |
| #610 many: add reactive charm plugin | charmcraft | closed | PR #610 (charm-tools-based reactive plugin) was closed unmerged on 2021-12-14 by sergiusens in favor of #613, which reimplemented the plugin on the charm tool (CRAFT-699) and merged as 32c8650a. | |
| #2194 Builds of charm using reactive plugin produces different config option | charmcraft | closed | Fixed by merged PR #2245 (commit aa28f0dc): reactive-generated config.yaml is no longer overwritten, preserving options such as snapd_refresh. |