← Back to issue list

chore: update to the latest craft-application

View original Github issue

Metadata

Project
rockcraft
Number
#506
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after craft-application 2.0's required build_plan argument broke test helpers; the draft went inactive. A later port landed in commit de242431.

Resolution: closed stale

Reason: PR #506 was closed without a recorded closing resolution after run_mocked_lifecycle failed because build_plan was missing. The author moved it to draft, a maintainer offered to take over, and no further PR activity followed; commit de242431 later performed the craft-app port.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This is prep work for the upcoming PR that will deal with the breaking change in https://github.com/canonical/craft-application/pull/259

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Closed unmerged after craft-application 2.0's required build_plan argument broke test helpers; the draft went inactive. A later port landed in commit de242431.
stealth/space-bunny-alpha — closed stale Rockcraft #506 was closed unmerged after tests failed on a missing build_plan argument; its prep work for canonical/craft-application#259 then went inactive.
stealth/space-bunny-alpha — closed stale Closed unmerged after the craft-application update failed on a required build_plan argument; follow-up was deferred until craft-application 2.0 was tagged.
qwen/qwen3.6-35b-a3b — — PR updated craft-application to latest version but was closed due to failing tests requiring additional changes. Author left for the week, and reviewer offered to take over after craft-app 2.0 tag.
qwen3.6-35b-a3b-mtp-q6 — — Abandoned due to test failures from upstream breaking changes. Work deferred until craft-app 2.0 is tagged. The PR remains closed and superseded by future updates.

Update history

No update history recorded yet.

Related work

  • Caused By: canonical/craft-application#259 (confidence 100%)

    The cited upstream breaking API change introduced the build_plan requirement that broke PR #506's tests.

Related issues

Issue Project State Summary Similarity
#1661 chore(deps): update dependency craft-application to v2.5.0 charmcraft merged Renovate PR #1661 was merged (commit 738a3ffe), bumping craft-application from ==2.4.0 to ==2.5.0 in two dependency files. Approved by 2 reviewers and auto-merged.
78%
#1669 chore(deps): update dependency craft-application to v2.7.0 charmcraft merged Merged PR #1669, upgrading craft-application from 2.6.3 to 2.7.0 in commit 3f9a94e6.
77%
#1327 chore(deps): update craft-application charmcraft merged Merged charmcraft#1327, updating craft-application across three files (+11/−9) after approval by two reviewers.
76%
#2047 chore: remove deprecated craft-application calls charmcraft closed Closed unmerged; its deprecated craft-application API cleanup was superseded by #2360, merged as 5e0dd360 in the broader craft-application 5 upgrade.
76%
#1465 chore(deps): update dependency craft-application to 1.2.1 charmcraft merged Merged charmcraft#1465 via commit f88283ed, updating craft-application to version 1.2.1 in two files.
75%
#4738 chore(deps): update dependency craft-application to v2.5.0 snapcraft merged Merged into main via commit 49ae242d9, upgrading craft-application from 2.4.0 to 2.5.0 with fixes needed for Snapcraft 8.2.0.
75%
#699 chore: test craft-cli changes rockcraft closed Temporary test PR for canonical/craft-cli#271 was closed unmerged after ~2 years idle: no reviews, CI, comments, or resolving commit. The craft-cli change itself landed separately in 73e896e.
75%
#431 chore(deps): update internal packages rockcraft merged Renovate PR merged into main as commit 0a5b2645, bumping craft-application 1.0.0→1.1.0, craft-parts 1.25.2→1.26.0 and craft-providers 1.20.0→1.20.1; approved by 2 reviewers with no unresolved comments or failing CI.
74%
#5166 chore!: use dev craft-parts snapcraft closed Closed unmerged as a test branch; #5149 superseded it and added Git as craft.git in commit c7d11ac65.
74%
#486 chore(merge): 'main' into 'work/CRAFT-3154/craft-platforms' craft-application closed Closed unmerged after prolonged inactivity, with no reviews or CI. Pydantic 2 had landed via #401 (c2f0978a); craft-platforms work later continued in #495 (3bd339cf).
74%