← Back to issue list

fix(common.mk): get upstream setup-lint

View original Github issue

Metadata

Project
charmcraft
Number
#2056
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a fix to restore the upstream setup-lint target in common.mk after a pyright dependency removal caused a regression. Approved by two reviewers with zero unresolved comments.

Suggested action:

No scores available.

Issue body

I messed this up when I removed the pyright dep from uv

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix to restore the upstream setup-lint target in common.mk after a pyright dependency removal caused a regression. Approved by two reviewers with zero unresolved comments.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to restore the upstream setup-lint configuration in common.mk after a pyright dependency removal from uv broke the build. The maintainer corrected the oversight and successfully merged the change.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to restore the upstream setup-lint configuration in common.mk after removing the pyright dependency from uv broke the linting setup.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#501 fix: help formatting when running `make -f common.mk` starbase merged Merged upstream fix for help formatting when running make -f common.mk. Approved by two reviewers, passed all CI checks, and resolved via a single-line change.
72%
#332 fix(common.mk): fix glob of prettier files starbase merged Merged a one-line update to common.mk that corrected the glob pattern for prettier files. Approved by one reviewer, the change was successfully integrated with zero unresolved comments and no CI failures.
72%
#324 fix(common.mk): docs ignores starbase merged Merged a single-line update to common.mk that corrects documentation ignore patterns. The change received approval from two reviewers, passed CI validation, and implements fixes referenced in PR #2096.
72%
#1105 fix: correct common.mk help target listing rockcraft merged Merged a fix for common.mk help target listing by preserving target names during Makefile parsing, resolving issue #941. Approved by three reviewers and merged after unrelated CI failures were confirmed as environmental noise.
72%
#237 style: fix pyright config craft-cli merged Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated.
70%