← Back to issue list

test(spread): per-base destructive mode tests

View original Github issue

Metadata

Project
charmcraft
Number
#2379
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged following approval by two reviewers. Added per-base destructive mode tests for spread and removed a redundant uv test. Changes were integrated despite mixed CI results.

Suggested action:

No scores available.

Issue body

Also removes the uv test since that is now redundant. Broken spread tests are not related.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval by two reviewers. Added per-base destructive mode tests for spread and removed a redundant uv test. Changes were integrated despite mixed CI results.
qwen3.6-35b-a3b-mtp-q6 Merged. Adds per-base destructive mode tests for spread and removes the now-redundant uv test. Unrelated broken spread tests were acknowledged but excluded from scope.
qwen3.6-35b-a3b-mtp-q6 Merged, adding per-base destructive mode tests for spread and removing a redundant uv test. Unrelated broken spread tests were noted as out of scope.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration.
77%
#13 test(spread): add more spread tests snapcraft-rocks merged Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines).
76%
#3020 spread tests: default base for local plugin tests snapcraft merged Merged updates to spread tests establishing a default base for local plugin tests. The change follows a prior commit pattern, adding two lines across two files. Approved by one reviewer and passed CI checks.
76%
#127 Fix spread tests imagecraft merged Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).
75%
#534 test(spread): workaround for flaky test fetch-service merged Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks.
75%
#1366 tests(spread): make release test less flaky charmcraft merged Merged changes that reduce flakiness in the spread release test, resolving issue #1362. Approved by two reviewers, the update modifies one file (+17/-7) after addressing feedback.
75%
#62 spread: add a "big" spread test rockcraft merged Merged a reusable spread test framework to house multiple checks without repeated setup. The initial test validates bug #44 regarding directory permissions. Approved by one reviewer and passed CI checks.
74%
#1464 ci: split spread tests by system charmcraft closed Merged after approval to split spread tests by system, reducing repetition and failure rates. The change modified two files with a minimal diff.
74%
#6202 test(spread): create core26 spread test suite snapcraft merged Merged the core26 spread test suite, adding CI jobs and generalizing tests for core22, 24, and 26 across 419 files. Approved by two reviewers and passed most CI checks prior to integration.
74%
#1290 test(spread): clean up store tests charmcraft merged Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers.
74%