fix: update to craft-application latest
Metadata
Current evaluation
Merged. Consolidates fixes from PRs #4616, #4643, and #4651 to update craft-application to the latest version and accommodate its main branch breaking changes. Approved by two reviewers, passed CI, and successfully merged.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
#4616, #4643, and #4651 all accommodate for different breaking changes in craft-application's main branch.
This PR has a commit for each of those PRs.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Consolidates fixes from PRs #4616, #4643, and #4651 to update craft-application to the latest version and accommodate its main branch breaking changes. Approved by two reviewers, passed CI, and successfully merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to update craft-application to the latest version, incorporating breaking change fixes from PRs #4616, #4643, and #4651. Maintainer approved and landed the changes after verifying expected test behavior. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged an update to the latest craft-application version, consolidating fixes from three prior pull requests to address breaking changes in its main branch. Approved by the maintainer after confirming expected test failures. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1563 fix: breaking changes from craft-application main | charmcraft | merged | Merged to resolve breaking changes from craft-application main. Approved by two reviewers, the update modified five files (+46/-26 lines) and was successfully integrated into the codebase. | |
| #1454 build: update craft-application | charmcraft | merged | Merged after updating the craft-application dependency and adjusting test constants. Approved by two reviewers with no unresolved comments. Changes affect three files with minor line adjustments. | |
| #527 Merge craft-application update into main | rockcraft | merged | Merged the craft-application branch into main, updating the dependency to version 2.4.0. Approved by two reviewers, rebased onto main, and successfully passed CI checks before being rebase-merged. | |
| #4573 build(deps): use craft-application from main branch | snapcraft | merged | Merged dependency update switching to craft-application from the main branch. Approved by two reviewers, passed CI, and resolved linter and coverage notes. Changes modified 8 files with 65 additions and 45 deletions. | |
| #485 Update to craft-application@main | rockcraft | merged | Merged update to craft-application@main, implementing BuildPlanner changes and pruning obsolete code across 16 files. Approved by one reviewer with passing CI checks. | |
| #5349 refactor: rebase onto craft-application 5 | snapcraft | merged | Merged after two approvals. Rebases the codebase onto craft-application 5, updating 45 files and potentially resolving issue #5083. Aligns with related upstream craft-application fixes. | |
| #123 build(deps): update craft-cli and craft-application versions | imagecraft | merged | Merged update to craft-cli and craft-application dependency versions. Approved by two reviewers, passed CI checks, and modified two files with minor version bumps. | |
| #5593 build(deps): update craft-application to 5.4.0 | snapcraft | merged | Merged after approval by two reviewers. Updates the craft-application dependency to version 5.4.0 across two files. All required CI checks passed, and the change was successfully integrated. | |
| #968 build(deps): update craft-application | rockcraft | merged | Merged after updating craft-application for a CRAFT-4705 demo. Approved by two reviewers with most CI checks passing despite failing snap-tests. Changes affect 17 files with 95 additions and 27 deletions. | |
| #4691 build(deps): update craft-application to 2.1.0 | snapcraft | merged | Merged dependency update upgrading craft-application to 2.1.0. Approved by two reviewers, passed CI checks, and maintained full test coverage on modified lines. Changes span four files with a minimal diff. |