← Back to issue list

fix: update to craft-application latest

View original Github issue

Metadata

Project
snapcraft
Number
#4659
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4659 updated Snapcraft for the latest craft-application breaking changes, consolidating work from #4616, #4643, and #4651.

Resolution: closed resolved

Reason: PR #4659 merged with approval from two reviewers and no unresolved comments. It incorporated the commits accommodating craft-application's latest breaking changes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- #4616, #4643, and #4651 all accommodate for different breaking changes in craft-application's main branch. This PR has a commit for each of those PRs.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4659 updated Snapcraft for the latest craft-application breaking changes, consolidating work from #4616, #4643, and #4651.
stealth/space-bunny-alpha — closed resolved Merged PR #4659 updated Snapcraft for the latest craft-application breaking changes, consolidating fixes from #4616, #4643, and #4651.
stealth/space-bunny-alpha — closed resolved Merged PR #4659 updated Snapcraft for craft-application’s latest breaking changes, consolidating commits from PRs #4616, #4643, and #4651.
qwen/qwen3.6-35b-a3b — — Merged. Consolidates fixes from PRs #4616, #4643, and #4651 to update craft-application to the latest version and accommodate its main branch breaking changes. Approved by two reviewers, passed CI, and successfully merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged to update craft-application to the latest version, incorporating breaking change fixes from PRs #4616, #4643, and #4651. Maintainer approved and landed the changes after verifying expected test behavior.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4616 (confidence 99%)

    Its build-environment compatibility commit was consolidated into #4659.

  • Related To: canonical/snapcraft#4643 (confidence 99%)

    Its build-plan test fixes were consolidated into #4659.

  • Related To: canonical/snapcraft#4651 (confidence 99%)

    Its configure_services compatibility fix, including commit 7814ba73e, was included in #4659.

Related issues

Issue Project State Summary Similarity
#5336 Update snapcraft to craft-application 5 snapcraft closed Snapcraft was rebased onto craft-application 5 by merged PR #5349 (commit ddbf2a6f8), completing the upgrade requested to unblock #5270.
82%
#4573 build(deps): use craft-application from main branch snapcraft merged Merged PR #4573 as commit 1366effa9, updating Snapcraft to use craft-application from its main branch.
81%
#968 build(deps): update craft-application rockcraft merged Merged PR #968 as commit c7374777, updating craft-application for a CRAFT-4705 demo. It landed after approval despite a failing snap-tests check.
78%
#4614 feat(craft-application): migrate version command snapcraft merged Merged PR #4614 (commit 885106d06) migrated Snapcraft's version command to craft-application, resolving #4468; legacy version handling remained out of scope.
78%
#1366 build(deps): bump craft-application to 7.2.1 rockcraft closed Closed unmerged as superseded by canonical/snapcraft#6409, which merged the same craft-application 7.2.1 bump in commit 25dd38674.
78%
#5349 refactor: rebase onto craft-application 5 snapcraft merged Merged in snapcraft#5349 as ddbf2a6f8, rebasing Snapcraft onto craft-application 5 and restoring .snapcraft.yaml project detection for core24.
77%
#553 docs(changelog): add 4.4.0 release notes craft-application merged Merged PR #553 added craft-application 4.4.0 release notes for the Snapcraft #5129 release cut in commit e367176e.
76%
#4738 chore(deps): update dependency craft-application to v2.5.0 snapcraft merged Merged into main via commit 49ae242d9, upgrading craft-application from 2.4.0 to 2.5.0 with fixes needed for Snapcraft 8.2.0.
75%
#244 fix: adapt to craft-application v6 breaking changes imagecraft closed Closed unmerged and superseded by imagecraft#261, which merged as fa39f80 to upgrade to craft-application 6 and require summary and description.
75%
#4691 build(deps): update craft-application to 2.1.0 snapcraft merged Renovate-style dependency bump of craft-application to 2.1.0 merged via PR #4691 (commit 1293b463d), changing 4 files (+4/-4) after approval by 2 reviewers; later superseded by further craft-application bumps.
74%