feat: craft-application rebase
Metadata
Current evaluation
Merged PR #1399 (commit 3ba803d1) rebased Charmcraft onto craft-application for CRAFT-2239, a 109-file rewrite of the CLI foundation; cmatsuoka approved merging with remaining issues deferred to follow-up PRs.
Resolution: closed resolved
Reason: The PR was merged into main as commit 3ba803d1 with two approvals; maintainer cmatsuoka commented it was 'functional enough to be merged', with outstanding issues to be handled in forthcoming PRs. It also closed the tracking issue #1133.
Evaluated by: mr-cal-bot
No scores available.
Issue body
CRAFT-2239
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1399 (commit 3ba803d1) rebased Charmcraft onto craft-application for CRAFT-2239, a 109-file rewrite of the CLI foundation; cmatsuoka approved merging with remaining issues deferred to follow-up PRs. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/charmcraft#1399, rebasing Charmcraft onto craft-application for CRAFT-2239; reviewers deemed the 109-file change functional and deferred remaining issues to follow-up PRs. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged the craft-application rebase. The change was approved as functionally stable for immediate integration, with remaining issues deferred to follow-up pull requests. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1133
(confidence 92%)
Tracking issue 'Rebase Charmcraft onto craft-application' that this PR resolved and closed.
-
Related To:
canonical/charmcraft#1419
(confidence 45%)
Follow-up cleanup commit removing the non-craft-application analyze command during the same rebase effort.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1133 Rebase Charmcraft onto craft-application | charmcraft | closed | Tracking issue for rebasing Charmcraft onto craft-application; delivered by merged PR #1399 'feat: craft-application rebase' (commit 3ba803d1, CRAFT-2239), a 109-file rewrite of the CLI foundation. | |
| #395 refactor: merge feature/craft-application | rockcraft | merged | Merged PR #395 into main, completing the breaking migration to craft-application 1.0.0 and resolving seven linked migration and command issues. | |
| #1544 feat: update charmcraft to use craft-application from main | charmcraft | merged | Merged #1544 to track craft-application main for CRAFT-2543; follow-up #1596 later pinned the released 2.0.0 dependency. | |
| #4444 feat: initial craft-application work | snapcraft | closed | Closed unmerged after prolonged inactivity; initial craft-application support later landed via merged PR #4560 at commit 98550856e. | |
| #1340 feat(craft-app): move init command | charmcraft | merged | PR #1340 by lengau merged, relocating charmcraft's init command into craft-application (with the init service/command/tests) plus lint fixes (+500/-343, 18 files). Later cleanup commit 97fa9229 (#1520) removed the old implementation. | |
| #6 base: craft-application prototype | craft-application | merged | Merged the initial craft-application prototype in canonical/craft-application#6, changing 21 files (+1029/-204); fuller tests were deferred to a follow-up PR. | |
| #4545 Merge feature/craft-application to main | snapcraft | closed | Merged initial craft-application support into main via PR #4560 at commit 98550856e, completing the requested feature-branch integration. | |
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged PR #1571 as commit 053d5a2d, removing the obsolete Charmcraft clean command and regression tests after craft-application took over clean handling. | |
| #316 Rebase "rockcraft pack" onto craft-application framework | rockcraft | closed | Rebased rockcraft pack onto craft-application in PR #354 (8d74e452); PR #395 later merged feature/craft-application into main, completing the migration to craft-application 1.0.0. | |
| #1327 chore(deps): update craft-application | charmcraft | merged | Merged charmcraft#1327, updating craft-application across three files (+11/−9) after approval by two reviewers. |