← Back to issue list

feat: craft-application rebase

View original Github issue

Metadata

Project
charmcraft
Number
#1399
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests.

Suggested action:

No scores available.

Issue body

CRAFT-2239

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests.
qwen3.6-35b-a3b-mtp-q6 Merged the craft-application rebase. The change was approved as functionally stable for immediate integration, with remaining issues deferred to follow-up pull requests.
qwen3.6-35b-a3b-mtp-q6 Merged the craft-application rebase PR (CRAFT-2239). Changes were approved as functionally sufficient for immediate integration. Remaining issues will be addressed in subsequent pull requests.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5349 refactor: rebase onto craft-application 5 snapcraft merged Merged after two approvals. Rebases the codebase onto craft-application 5, updating 45 files and potentially resolving issue #5083. Aligns with related upstream craft-application fixes.
84%
#856 refactor: use craft-application 5 rockcraft merged Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed.
83%
#1563 fix: breaking changes from craft-application main charmcraft merged Merged to resolve breaking changes from craft-application main. Approved by two reviewers, the update modified five files (+46/-26 lines) and was successfully integrated into the codebase.
82%
#1330 feat(craft-app): Add craft-application services charmcraft merged Merged feat(craft-app): Add craft-application services. Approved by two reviewers, the change modified 56 files with 2143 additions and 230 deletions. The author fixed changelist misalignments causing spread test failures before merge.
81%
#4560 feat(craft-application): initial support snapcraft merged Merged initial craft-application support, acting as a fallback to existing logic. Approved by two reviewers with no unresolved comments. Changes affect 40 files, adding 887 lines and removing 197. Additional features are planned.
80%
#395 refactor: merge feature/craft-application rockcraft merged Merged feature/craft-application into main, completing Rockcraft's migration to craft-application 1.0.0. The refactoring modified 99 files, resolved multiple issues, and introduced breaking changes. Approved by two reviewers with passing CI.
80%
#4573 build(deps): use craft-application from main branch snapcraft merged Merged dependency update switching to craft-application from the main branch. Approved by two reviewers, passed CI, and resolved linter and coverage notes. Changes modified 8 files with 65 additions and 45 deletions.
80%
#576 feat: extend craft_application.git module craft-application merged Merged after approval from three reviewers and passing CI checks. The update extends the craft_application.git module by adding GitRepo methods for remote URL management, commit verification, fetch operations, and subprocess integration.
79%
#527 Merge craft-application update into main rockcraft merged Merged the craft-application branch into main, updating the dependency to version 2.4.0. Approved by two reviewers, rebased onto main, and successfully passed CI checks before being rebase-merged.
79%
#4654 chore: merge feature/components into feature/craft-application snapcraft merged Merged feature/components into feature/craft-application following three reviewer approvals. The update modified 28 files with over 1500 additions and 68 deletions. Test and CI issues were resolved during review before final integration.
79%