← Back to issue list

fix: use `charmcraft pack` instead of `charmcraft pull` in different-dir-metadata spread test

View original Github issue

Metadata

Project
charmcraft
Number
#2672
Type
pull request
State
closed
Author
Copilot
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged: the charmcraft pull -> pack fix for the different-dir-metadata spread test was superseded by PR #2694, merged as commit dd684338 using `charmcraft pack --verbose --project-dir=charm` plus output/restore checks.

Resolution: closed superseded

Reason: PR #2672 was never merged; the same spread-test fix landed via PR #2694, merged as commit dd684338, which replaced `charmcraft pull` with `charmcraft pack --verbose --project-dir=charm` and added artifact verification and cleanup to task.yaml.

Evaluated by: mr-cal-bot

No scores available.

Issue body

## Summary Fixes the broken spread test at https://github.com/canonical/charmcraft/actions/runs/24746125338/job/72401080632. The `tests/spread/smoketests/different-dir-metadata` task was using `charmcraft pull` which doesn't exist as a command. Changed it to `charmcraft pack` to correctly test packing a charm with separate metadata files from a different directory. ## Changes - `tests/spread/smoketests/different-dir-metadata/task.yaml`: Replace `charmcraft pull` with `charmcraft pack`

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged: the charmcraft pull -> pack fix for the different-dir-metadata spread test was superseded by PR #2694, merged as commit dd684338 using `charmcraft pack --verbose --project-dir=charm` plus output/restore checks.
stealth/space-bunny-alpha — closed superseded Closed in favor of merged PR #2694 (commit dd684338), which replaced the invalid charmcraft pull invocation with charmcraft pack --project-dir=charm and added output verification and cleanup.
stealth/space-bunny-alpha — closed superseded PR #2672 (fix typo `pull` -> `pack` in different-dir-metadata spread test) was closed unmerged; superseded by merged PR #2694 (commit dd684338), which uses `charmcraft pack --verbose --project-dir=charm` plus output/cleanup checks.
stealth/space-bunny-alpha — closed resolved Merged PR #2694 (commit dd684338), updating different-dir-metadata to use charmcraft pack --project-dir=charm, verify the output, and clean it up.
qwen/qwen3.6-35b-a3b — — Merged a fix for a broken spread test by replacing the invalid charmcraft pull command with charmcraft pack in the different-dir-metadata task configuration. This update corrects the test execution and resolves the failure.
qwen/qwen3.6-35b-a3b — — Closed after replacing the invalid charmcraft pull command with charmcraft pack in the different-dir-metadata spread test to fix a broken CI check. The change updates task.yaml to correctly test packing charms with separate metadata files.
qwen/qwen3.6-35b-a3b — — Merged a fix for a broken spread test by replacing the non-existent charmcraft pull command with charmcraft pack in the different-dir-metadata test configuration. The update corrected the test execution and passed CI checks.
qwen/qwen3.8-27b
Impact: 10
Quick Win: 10
Staleness: 80
Complexity: 5
Confidence: 90
close stale Replaces nonexistent `charmcraft pull` with `charmcraft pack` in the different-dir-metadata spread test. Pending, 0 reviewers, inactive 128 days. Same fix already merged via #2694 (pack --project-dir), so this PR is superseded.
qwen/qwen3.8-27b
Impact: 10
Quick Win: 10
Staleness: 80
Complexity: 5
Confidence: 92
close stale Replaces non-existent `charmcraft pull` with `charmcraft pack` in the different-dir-metadata spread test. 2-line test-only change, 128 days inactive, no review. Same fix already merged via #2694, which uses `pack --project-dir` and adds output verification.
qwen3.6-35b-a3b-mtp-q6
Staleness: 65
Complexity: 10
Confidence: 75
needs review Replaces charmcraft pull with charmcraft pack in a spread test to fix a broken test. Currently pending maintainer review with passing CI, though pre-existing type-checking warnings are noted.
qwen3.6-35b-a3b-mtp-q6
Staleness: 65
Complexity: 5
Confidence: 80
needs review Replaces charmcraft pull with charmcraft pack in a spread test to fix a broken test. Currently inactive for 76 days and awaiting maintainer review.
qwen3.6-35b-a3b-mtp-q6
Staleness: 65
Complexity: 5
Confidence: 85
needs review Fixes a broken spread test by replacing the non-existent charmcraft pull command with charmcraft pack in the different-dir-metadata task. Currently awaiting maintainer review after 73 days of inactivity.

Update history

Date Change
closed

Related work

  • Superseded By: canonical/charmcraft#2694 (confidence 95%)

    Merged PR #2694 / commit dd684338 is the only change to tests/spread/smoketests/different-dir-metadata/task.yaml, landing the pack-instead-of-pull fix that #2672 proposed.

  • Related To: canonical/charmcraft#2644 (confidence 55%)

    Commit c87eca0d (#2644) previously touched the same spread test while fixing metadata lookup under --project-dir; #2672/#2694 fix the test broken/incorrect after that work.

Related issues

Issue Project State Summary Similarity
#2694 test(different-dir-metadata): use pack --project-dir instead of pull charmcraft merged Merged PR #2694 (commit dd684338) fixed the failing different-dir-metadata spread test by switching `charmcraft pull` to `charmcraft pack --verbose --project-dir=charm`, plus output and restore checks.
89%
#2498 fix: `charmcraft pack --project-dir` with metadata.yaml charmcraft closed Closed unmerged; superseded by #2644, which fixed metadata lookup for --project-dir and shipped in Charmcraft 4.2.1.
82%
#2600 fix: make the -p and -o arguments work correctly charmcraft merged Merged PR #2600 (commit 868da353), fixing charmcraft pack to honor --project-dir and apply --output outside the container; this closes #1930.
75%
#1950 fix: make charmcraft work with snap parallel installs charmcraft merged Merged PR #1950 via commit 2399ddf8, fixing Charmcraft conflicts during parallel snap installs and adding spread regression coverage for issue #1770.
74%
#2804 Fix spread different-dir artifact output handling charmcraft open Maintainer fix for pack artifact relocation: resolves --project-dir/output to absolute paths pre-pack, keeps state-based move and adds a .charm glob fallback; +124/-3 with unit tests. Fast tests pass, 6 CI jobs pending, 73d idle.
73%
#1619 fix: use charmcraft package version charmcraft merged Merged PR #1619 as commit 15fac367, replacing the previous version source with the Charmcraft package version in a one-line fix.
72%
#2493 Packing fails when using a separate metadata.yaml file and `--project-dir` argument charmcraft closed Fixed by PR #2644 (c87eca0d), which loads separate metadata.yaml from the correct project directory. The fix was slated for Charmcraft 4.2.1.
71%
#821 5.5.0 changes pack semantics if the project file has different metadata craft-application open Metadata-only charmcraft.yaml edits were skipped as "Already packed," leaving stale .charm artifacts; Charmcraft PR #2890 is reported to fix repacking after the edit.
71%
#416 Updated directory missing in `charmcraft` pull step craft-parts closed Fixed skipped updated directories during Charmcraft PULL by merging craft-parts#417 (commit e7018745), which safely removes entries after iteration.
71%
#2890 feat: skip repacking if project is not changed charmcraft merged Merged PR implementing metadata mediation for config.yaml and actions.yaml so charmcraft skips repacking unchanged projects; fixes #2858 and canonical/craft-application#821.
70%