test(different-dir-metadata): use pack --project-dir instead of pull
Metadata
Current evaluation
Updates a spread test to use charmcraft pack instead of pull for proper --project-dir support, with recent revisions addressing reviewer feedback and currently awaiting review.
Suggested action: needs review
Reason: The PR has been updated in response to maintainer feedback to correctly use the `pack` command and includes a cleanup step. It now requires a maintainer code review to approve the test fix and verify that the reported type-checking failures are pre-existing or unrelated to this change.
Staleness:
25
Complexity:
5
Confidence:
75
Issue body
`charmcraft pull` doesn't accept `--project-dir`, causing the `different-dir-metadata` spread test to fail with `unrecognized arguments: --project-dir=charm`.
## Change
Replace `charmcraft pull --verbose --project-dir=charm` with `charmcraft pack --verbose --project-dir=charm`, which correctly supports the `--project-dir` flag and preserves the test's purpose of verifying that a charm with separate metadata files can be packed from a different directory.
```diff
- charmcraft pull --verbose --project-dir=charm
+ charmcraft pack --verbose --project-dir=charm
+ test -f tester-grpc*.charm
```
A `restore` step is also added to clean up the produced charm file after the test runs.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| 2026-06-15 11:06:31.941226+00:00 | qwen3.6-35b-a3b-mtp-q6 |
Staleness:
25
Complexity:
5
Confidence:
75
|
needs review | Updates a spread test to use charmcraft pack instead of pull for proper --project-dir support, with recent revisions addressing reviewer feedback and currently awaiting review. |
| 2026-06-15 11:03:45.409577+00:00 | pending | — | — | — |