← Back to issue list

Fix spread different-dir artifact output handling

View original Github issue

Metadata

Project
charmcraft
Number
#2804
Type
pull request
State
open
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Fixes artifact output directory handling when using --project-dir with spread tests; adds unit regressions. Awaiting human review with 2 unresolved automated comments.

Suggested action: needs review

Reason: This is a legitimate bug fix from maintainer lengau addressing artifact relocation when --project-dir differs from output dir. It adds unit tests (test_move_artifacts_to_output_dir, test_move_artifacts_creates_output_dir) and a fallback mechanism. However, it has sat 46 days with 0 human comments and 2 unresolved automated review comments, so a maintainer review is needed to address those comments and merge.

Impact: 50 Quick Win: 35.0 Staleness: 55 Complexity: 30 Confidence: 70

Issue body

## Summary - resolve --project-dir and output directories before running pack so relocation uses stable absolute paths - keep state-based artifact relocation and add a fallback that moves remaining .charm files from project dir to output dir - add unit regressions for relative project-dir and missing artifact-state fallback ## Validation - uv run pytest tests/unit/commands/test_lifecycle.py -k move_artifacts - spread -v multipass:ubuntu-22.04-64:tests/spread/smoketests/different-dir via spread-plus

Evaluation history

Date Model Scores Action Summary
qwen3.6-35b-a3b-mtp-q6
Impact: 50
Quick Win: 35.0
Staleness: 55
Complexity: 30
Confidence: 70
needs review Fixes artifact output directory handling when using --project-dir with spread tests; adds unit regressions. Awaiting human review with 2 unresolved automated comments.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 25
Confidence: 90
needs review Resolves project and output directories before pack to ensure stable paths for artifact relocation. Adds fallback logic and unit tests. Currently pending maintainer review with 2 unresolved comments and minor CI title policy failure.
qwen3.6-35b-a3b-mtp-q6
Staleness: 0
Complexity: 45
Confidence: 90
needs review Fixes artifact output path resolution and adds a fallback relocation mechanism with unit tests. Currently awaiting maintainer review and CI validation.

Update history

Date Change
created

Related issues

No related issues found above the similarity threshold.