← Back to issue list

test(spread): fix different-dir task assertions

View original Github issue

Metadata

Project
charmcraft
Number
#2785
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Maintainer PR (2 files, +6/-5) updating spread different-dir / different-dir-metadata assertions to match where artifacts land with --project-dir, plus restore cleanup. Fixes tests failing on main; CI green, 2 checks pending, 1 review comment unresolved, idle 80 days.

Suggested action: needs review

Reason: Test-only fix authored by a maintainer (lengau) targeting two spread tasks described as "failing on main"; all reported checks pass except two still queued (snap-store-tests, spread-select) and one review comment remains unresolved. Impact is limited to unblocking spread CI (no product code), but it is small, correct in intent, and unblocked.

Evaluated by: mr-cal-bot

Impact: 27 Quick Win: 13 Complexity: 10 Confidence: 68 Actionability: 55

Issue body

Summary:\n- update different-dir spread assertions to match where artifacts are produced when using --project-dir\n- update different-dir-metadata assertions to check artifact placement under the project directory\n- clean up both possible artifact locations in restore\n\nContext:\nThese two tasks are failing on main due to output-location assertions that no longer match runtime behavior in CI logs.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 27
Quick Win: 13
Complexity: 10
Confidence: 68
Actionability: 55
needs review Maintainer PR (2 files, +6/-5) updating spread different-dir / different-dir-metadata assertions to match where artifacts land with --project-dir, plus restore cleanup. Fixes tests failing on main; CI green, 2 checks pending, 1 review comment unresolved, idle 80 days.
stealth/space-bunny-alpha
Impact: 30
Quick Win: 18
Complexity: 18
Confidence: 89
Actionability: 75
needs review Updates two spread tasks’ assertions for --project-dir artifact locations and cleans up restore locations. Reported checks pass, but review is pending after 72 days and two checks remain queued.
stealth/space-bunny-alpha
Impact: 22
Quick Win: 14
Complexity: 8
Confidence: 84
Actionability: 68
needs review Updates two spread tests to match --project-dir artifact locations and cleans both locations during restore; most CI passes, with two checks and one review comment outstanding.
qwen3.6-35b-a3b-mtp-q6
Impact: 15
Quick Win: 13
Staleness: 45
Complexity: 15
Confidence: 70
needs review Fixes spread test assertions for different-dir tasks to match --project-dir artifact output locations. Small change (+6/-5, 2 files), CI passing, authored by maintainer, no review activity.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 10
Confidence: 90
needs review Updates spread test assertions for different-dir tasks to match current artifact placement under --project-dir. Fixes failing CI tests on main. Currently pending review with 1 unresolved comment and 2 pending CI checks.
qwen3.6-35b-a3b-mtp-q6
Staleness: 0
Complexity: 10
Confidence: 95
needs review Updates spread test assertions for different-dir tasks to match current --project-dir artifact placement, fixing failing CI checks. Cleans up artifact location handling in restore.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#2694 (confidence 72%)

    Earlier merged PR (commit dd684338) reworked the same different-dir-metadata task to use `pack --project-dir=charm`; this PR adjusts the follow-up output-location assertions and restore paths for that task.

Related issues

Issue Project State Summary Similarity
#2804 Fix spread different-dir artifact output handling charmcraft open Maintainer fix for pack artifact relocation: resolves --project-dir/output to absolute paths pre-pack, keeps state-based move and adds a .charm glob fallback; +124/-3 with unit tests. Fast tests pass, 6 CI jobs pending, 73d idle.
82%
#127 Fix spread tests imagecraft merged Fixed and merged as commit cd43de1, updating 11 files (+49/-38); all listed CI checks, including spread, passed.
73%
#926 test: address a couple of non-flaky spread failures rockcraft merged Merged PR #926 updated three spread-test configuration files to address persistent failures; all CI checks passed and two reviewers approved.
72%
#399 test(spread): retry restore cleanup for pack tests imagecraft closed PR #399 was closed unmerged after 51 days with seven unresolved review comments and one failing spread job; its restore-cleanup retry changes were not incorporated.
72%
#13 test(spread): add more spread tests snapcraft-rocks merged Merged PR #13 added Spread tests for architectures, Chisel slices, craftctl, package repositories, and patchelf (+206/-5 across 15 files).
72%
#486 test(spread): clean up plugin prep/restore imagecraft merged Merged PR #486 refactors spread tests by moving plugin preparation and restoration logic into common prepare-each and restore-each scripts, reducing task file size and improving maintainability.
71%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%.
71%
#1266 tests(spread): requirements dependencies charmcraft merged Merged PR #1266 at 97d95b39, adding spread tests for requirements-file and charm-dependency combinations; the PR explicitly fixes #1179.
71%
#2694 test(different-dir-metadata): use pack --project-dir instead of pull charmcraft merged Merged PR #2694 (commit dd684338) fixed the failing different-dir-metadata spread test by switching `charmcraft pull` to `charmcraft pack --verbose --project-dir=charm`, plus output and restore checks.
71%
#3662 tests: update spread url snapcraft merged Merged PR #3662 updated Spread tarball URLs in two test files via commit 507959d70.
70%