← Back to issue list

test(spread): fix different-dir task assertions

View original Github issue

Metadata

Project
charmcraft
Number
#2785
Type
pull request
State
open
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Fixes spread test assertions for different-dir tasks to match --project-dir artifact output locations. Small change (+6/-5, 2 files), CI passing, authored by maintainer, no review activity.

Suggested action: needs review

Reason: This is a small, focused test fix (+6/-5 lines) authored by a maintainer with all CI checks passing. The PR updates spread test assertions to match current runtime behavior for --project-dir artifact placement. It has received no review comments in 53 days and needs maintainer review to proceed.

Impact: 15 Quick Win: 12.75 Staleness: 45 Complexity: 15 Confidence: 70

Issue body

Summary:\n- update different-dir spread assertions to match where artifacts are produced when using --project-dir\n- update different-dir-metadata assertions to check artifact placement under the project directory\n- clean up both possible artifact locations in restore\n\nContext:\nThese two tasks are failing on main due to output-location assertions that no longer match runtime behavior in CI logs.

Evaluation history

Date Model Scores Action Summary
qwen3.6-35b-a3b-mtp-q6
Impact: 15
Quick Win: 12.75
Staleness: 45
Complexity: 15
Confidence: 70
needs review Fixes spread test assertions for different-dir tasks to match --project-dir artifact output locations. Small change (+6/-5, 2 files), CI passing, authored by maintainer, no review activity.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 10
Confidence: 90
needs review Updates spread test assertions for different-dir tasks to match current artifact placement under --project-dir. Fixes failing CI tests on main. Currently pending review with 1 unresolved comment and 2 pending CI checks.
qwen3.6-35b-a3b-mtp-q6
Staleness: 0
Complexity: 10
Confidence: 95
needs review Updates spread test assertions for different-dir tasks to match current --project-dir artifact placement, fixing failing CI checks. Cleans up artifact location handling in restore.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2804 Fix spread different-dir artifact output handling charmcraft open Fixes artifact output directory handling when using --project-dir with spread tests; adds unit regressions. Awaiting human review with 2 unresolved automated comments.
83%
#1083 ci: fix spread test missing PATH charmcraft merged Merged a fix for a CI spread test missing the PATH variable. The change updated four files and received reviewer approval. Post-merge validation confirmed the spread tests for configure and remove passed successfully.
74%
#127 Fix spread tests imagecraft merged Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).
73%
#534 test(spread): workaround for flaky test fetch-service merged Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks.
73%
#3662 tests: update spread url snapcraft merged Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage.
73%
#4433 tests(spread): add remote-build spread test snapcraft merged Merged changes adding spread tests for new and legacy remote-build, resolving issue #4398. Approved by two reviewers with passing CI checks.
73%
#2400 tests: fix maven spread test snapcraft merged Merged a +2/-0 change to fix the maven spread test. Authored by maintainer sergiusens, the update was integrated into the main branch without additional reviews or CI blockers.
72%
#3663 tests: update spread url snapcraft merged Merged following reviewer approval and passing CI. Updated spread tarball URLs in test configuration files, modifying two files with minimal changes.
72%
#13 test(spread): add more spread tests snapcraft-rocks merged Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines).
72%
#6408 Re-organize spread tests snapcraft open Enhancement to reorganize spread test directories, deduplicate tests, and remove unnecessary spread tests for faster CI. Triaged by maintainer, 8 days old.
72%