← Back to issue list

test: speed up spread test runtime by removing redundant package setup

View original Github issue

Metadata

Project
charmcraft
Number
#2774
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Removes redundant apt update calls and consolidates package installs in spread tests to reduce runtime. All CI passing, awaiting review of 1 unresolved comment.

Suggested action: needs review

Reason: Small, low-risk optimization (+2/-20 lines) with all CI checks passing. One unresolved review comment and 99 days of inactivity suggest the author needs to address feedback before merge, but the change itself is straightforward and beneficial.

Evaluated by: mr-cal-bot

Impact: 15 Quick Win: 8 Complexity: 10 Confidence: 75 Actionability: 60

Issue body

## Summary - remove a redundant apt update from top-level spread prepare - install snapd and unzip together in one global tests.pkgs call - remove per-task unzip installs from spread task.yaml files where unzip is already guaranteed globally ## Impact This removes repeated package-index refreshes in spread runs, reducing runtime while preserving test coverage and assertions.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b
Impact: 15
Quick Win: 8
Complexity: 10
Confidence: 75
Actionability: 60
needs review Removes redundant apt update calls and consolidates package installs in spread tests to reduce runtime. All CI passing, awaiting review of 1 unresolved comment.
stealth/space-bunny-alpha
Impact: 30
Quick Win: 18
Complexity: 14
Confidence: 92
Actionability: 68
needs review Consolidates Spread setup by removing a redundant apt update and per-task unzip installs; all completed checks pass, with snap-store-tests and two spread-select checks pending.
stealth/space-bunny-alpha
Impact: 28
Quick Win: 15
Complexity: 18
Confidence: 76
Actionability: 65
needs review Consolidates Spread package setup by removing redundant apt updates and unzip installs; completed CI passes, but snap-store-tests and two spread-select checks remain pending.
qwen3.6-35b-a3b-mtp-q6
Impact: 20
Quick Win: 17
Staleness: 75
Complexity: 15
Confidence: 70
close stale Optimizes spread test runtime by consolidating package installs and removing redundant apt updates across 11 test files
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 10
Confidence: 85
needs review Consolidates redundant package installations in spread test configuration to reduce runtime. Currently pending review with all CI checks passing.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 10
Confidence: 85
needs review Optimizes spread test configuration by removing redundant apt updates and per-task unzip installs, consolidating package setup globally to reduce CI runtime. Currently awaiting review and CI validation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#432 ci: speed up spread testing workflow fetch-service merged Merged PR #432 (commit 9eec284), removing snap-test's dependency on snap-build so spread tests start sooner while snap-build still produces downloadable artifacts.
75%
#5418 ci: speed up spread test suite snapcraft merged Merged PR #5418 (commit a5682c276, SNAPCRAFT-353) sped up the spread test suite from 1h40m to 40m: split slow tests into a manually triggered workflow, used wheels, added store retries, fixed the matter test. Fixes #5296.
74%
#944 test(spread): speed up the skip-retest spread test craft-application closed PR #944 was closed unmerged and superseded by craft-application#964, which carried the spread-test speedup changes forward and merged the adjusted repack-test setup.
73%
#926 test: address a couple of non-flaky spread failures rockcraft merged Merged PR #926 updated three spread-test configuration files to address persistent failures; all CI checks passed and two reviewers approved.
73%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%.
72%
#127 Fix spread tests imagecraft merged Fixed and merged as commit cd43de1, updating 11 files (+49/-38); all listed CI checks, including spread, passed.
71%
#573 ci: run spread tests on 'spread-installed' runners rockcraft merged Merged PR #573 as commit c8ff5823, updating CI to run Spread tests on runners labeled "spread-installed."
70%