← Back to issue list

chore: format pyproject.toml with tombi ahead of Starbase merge

View original Github issue

Metadata

Project
charmcraft
Number
#2898
Type
pull request
State
closed
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after its prep branch was dropped during the Starbase update; replacement PR #2899 merged as commit 8da01822.

Resolution: closed superseded

Reason: PR #2898 was closed rather than merged when the Starbase preparation was rebuilt and its branch was dropped. The replacement Starbase update, PR #2899, merged as commit 8da01822.

Evaluated by: mr-cal-bot

No scores available.

Issue body

## Why The upcoming Starbase merge wires `tombi` into `make format`/`make lint` for the first time. This PR pre-formats `pyproject.toml` with `tombi format` so the merge lands with a clean `lint-tombi` run. ## What - Run `tombi format pyproject.toml`. Purely mechanical: whitespace/indentation normalization and alphabetical reordering of dependency list entries. - `tests/spread/**/pyproject.toml` fixtures also need tombi formatting, but those are charm-project test samples introduced by the Starbase merge itself, so they're left for that merge to handle rather than touched here. ## Validation - Parsed TOML content (`tomllib`) confirmed structurally identical before/after, aside from the alphabetical reordering of list entries (order doesn't affect dependency resolution) - `uv lock --check`: still resolves cleanly against the reformatted file - `tombi format --check pyproject.toml`: passes

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged after its prep branch was dropped during the Starbase update; replacement PR #2899 merged as commit 8da01822.
stealth/space-bunny-alpha — closed superseded PR #2898 was closed unmerged as redundant after prep PR #2897 landed; it was superseded by merged Starbase update #2899 (8da01822).
stealth/space-bunny-alpha — closed superseded Closed unmerged; the standalone tombi reformat was dropped when Starbase update #2899 superseded the preparatory change.
stealth/space-bunny-alpha — closed superseded Closed unmerged; Starbase update charmcraft#2899 superseded the preparatory tombi formatting, so this change was dropped without a resolving commit.
stealth/space-bunny-alpha — closed stale PR #2898 was closed unmerged without a resolving commit; its mechanical tombi formatting was not landed, repeating the unmerged attempt in #2894.
stealth/space-bunny-alpha
Impact: 10
Quick Win: 4
Complexity: 30
Confidence: 65
Actionability: 50
keep open Mechanical `tombi format pyproject.toml` (1 file, +416/-395) run ahead of a Starbase merge that wires tombi into make format/lint. Approved by 2 reviewers, 0 unresolved comments, but 3 CI checks red; identical prior attempt #2894 was closed unmerged.
stealth/space-bunny-alpha
Impact: 12
Quick Win: 4
Complexity: 22
Confidence: 72
Actionability: 38
keep open Mechanical tombi reformat of pyproject.toml to pre-stage the Starbase merge; approved, but lint / files is failing (fixtures left unformatted) and tombi is not yet wired into this repo. Prior identical attempt #2894 was closed unmerged.
stealth/space-bunny-alpha
Impact: 15
Quick Win: 7
Complexity: 10
Confidence: 76
Actionability: 50
needs review Mechanical tombi reformat of pyproject.toml (+416/-395, 1 file) to pre-stage the upcoming Starbase merge. No functional change. Open, 0 reviewers, no comments; lint / files check is failing.
stealth/space-bunny-alpha
Impact: 14
Quick Win: 3
Complexity: 20
Confidence: 72
Actionability: 25
close not mergeable Purely mechanical `tombi format pyproject.toml` (+416/-395) pre-formatting ahead of a Starbase merge; repo has no tombi tooling yet. lint / files, snap-tests (22.04) and OSV-scanner CI fail; 0 reviews.
stealth/space-bunny-alpha
Impact: 13
Quick Win: 6
Complexity: 11
Confidence: 86
Actionability: 48
keep open Tombi-formats the root pyproject.toml before Starbase integration; core tests and policy checks pass, but file linting and OSV-scanner fail and snap builds remain pending.

Update history

Date Change
closed
updated
updated
updated
updated
created

Related work

  • Superseded By: canonical/charmcraft#2899 (confidence 98%)

    The Starbase update followed #2898 and was merged after #2898's branch was dropped.

  • Duplicate Of: canonical/charmcraft#2894 (confidence 96%)

    Earlier unmerged PR with the same title and mechanical tombi-formatting change.

Related issues

Issue Project State Summary Similarity
#2894 chore: format pyproject.toml with tombi ahead of Starbase merge charmcraft closed Superseded by #2898, which reapplied the tombi formatting and merged as f1af0486 ahead of the Starbase update in #2899.
92%
#435 chore: format pyproject.toml with tombi craft-store merged Merged PR formatting pyproject.toml with tombi for consistent TOML formatting ahead of starbasification.
87%
#436 chore: format pyproject.toml with tombi craft-store closed PR #436 was superseded by merged PR #435 (commit fe67242) which applied the same tombi formatting to pyproject.toml.
85%
#550 chore: move project configuration to pyproject.toml rockcraft closed Closed unmerged after prolonged inactivity; the configuration migration was later completed by merged PR #751 in commit bc45bedf.
77%
#2895 chore(merge): update starbase (2026-09-24) charmcraft closed Draft Starbase sync PR #2895 (2026-09-24) was closed unmerged; the same update was reworked as #2899 (2026-09-28), which merged as commit 8da01822 after prep PRs #2897/#2898.
77%
#1213 style: format pyproject.toml with tombi craft-application merged Merged PR applying tombi formatting to pyproject.toml (2-space indent, canonical key ordering), decoupling the mechanical diff from the upcoming Starbase sync.
76%
#238 chore(merge): update starbase (2026-07-16) craft-archives closed PR #238 was closed unmerged after an external linkcheck timeout; its Starbase sync was later merged through replacement PR #252.
76%
#237 chore(merge): update starbase (2026-07-14) craft-archives closed PR #237 was closed unmerged after failing CI checks and leaving 29 review comments unresolved; no resolving commit was identified.
76%
#236 chore(merge): update starbase (2026-07-14) craft-archives closed Closed unmerged; the Starbase update was later merged through #252 in commit 1b56643.
75%
#236 chore(merge): update starbase (2026-06-18) craft-platforms closed Starbase sync PR #236 was closed unmerged; rebuilt replacement #270 later merged Starbase into main as commit 4afcee7.
75%