← Back to issue list

chore: format pyproject.toml with tombi ahead of Starbase merge

View original Github issue

Metadata

Project
charmcraft
Number
#2894
Type
pull request
State
closed
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Superseded by #2898, which reapplied the tombi formatting and merged as f1af0486 ahead of the Starbase update in #2899.

Resolution: closed superseded

Reason: PR #2894 was closed unmerged. The same formatting was reapplied in PR #2898 and merged as commit f1af0486 before Starbase PR #2899 merged as 8da01822.

Evaluated by: mr-cal-bot

No scores available.

Issue body

## Why The upcoming Starbase merge wires `tombi` into `make format`/`make lint` for the first time. This PR pre-formats `pyproject.toml` with `tombi format` so the merge lands with a clean `lint-tombi` run. ## What - Run `tombi format pyproject.toml`. Purely mechanical: whitespace/indentation normalization and alphabetical reordering of dependency list entries. - `tests/spread/**/pyproject.toml` fixtures also need tombi formatting, but those are charm-project test samples introduced by the Starbase merge itself, so they're left for that merge to handle rather than touched here. ## Validation - Parsed TOML content (`tomllib`) confirmed structurally identical before/after, aside from the alphabetical reordering of list entries (order doesn't affect dependency resolution) - `uv lock --check`: still resolves cleanly against the reformatted file - `tombi format --check pyproject.toml`: passes

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Superseded by #2898, which reapplied the tombi formatting and merged as f1af0486 ahead of the Starbase update in #2899.
stealth/space-bunny-alpha — closed superseded Closed unmerged and superseded by recreated PR #2898, which landed the same tombi formatting in commit f1af0486 before Starbase update #2899.
stealth/space-bunny-alpha — closed stale Closed unmerged before review; its mechanical tombi formatting was not landed ahead of the Starbase merge.
stealth/space-bunny-alpha
Impact: 10
Quick Win: 5
Complexity: 15
Confidence: 88
Actionability: 62
needs review Pre-formats pyproject.toml with tombi ahead of the Starbase merge; awaiting review, with OSV-scanner failing and several build/test checks pending.

Update history

Date Change
closed
created

Related work

  • Superseded By: canonical/charmcraft#2898 (confidence 99%)

    Replacement PR with the same title and tombi formatting change; merged as f1af0486.

  • Related To: canonical/charmcraft#2899 (confidence 98%)

    The subsequent Starbase update that motivated the formatting merged as 8da01822.

Related issues

Issue Project State Summary Similarity
#2898 chore: format pyproject.toml with tombi ahead of Starbase merge charmcraft closed Closed unmerged after its prep branch was dropped during the Starbase update; replacement PR #2899 merged as commit 8da01822.
92%
#435 chore: format pyproject.toml with tombi craft-store merged Merged PR formatting pyproject.toml with tombi for consistent TOML formatting ahead of starbasification.
88%
#436 chore: format pyproject.toml with tombi craft-store closed PR #436 was superseded by merged PR #435 (commit fe67242) which applied the same tombi formatting to pyproject.toml.
87%
#277 style: format pyproject.toml with tombi craft-platforms closed Merged as commit 14d9828, mechanically formatting pyproject.toml with tombi; the change was also folded into the Starbase update in #270.
82%
#1213 style: format pyproject.toml with tombi craft-application merged Merged PR applying tombi formatting to pyproject.toml (2-space indent, canonical key ordering), decoupling the mechanical diff from the upcoming Starbase sync.
81%
#200 style: format pyproject.toml with tombi debcraft merged Merged a mechanical reformat of pyproject.toml using tombi for indentation, quoting, and key ordering, preparing for the Starbase sync.
80%
#506 style: format pyproject.toml with tombi craft-cli merged Merged PR #506 mechanically reformats pyproject.toml with tombi to align with Starbase build tooling, containing no functional changes.
80%
#218 style: format pyproject.toml with tombi craft-grammar merged Merged PR formatting pyproject.toml with tombi to align with Starbase make format and make lint rules. Purely mechanical style changes.
78%
#451 style: format TOML files with tombi imagecraft closed Merged TOML formatting with tombi in squash commit 705d996, updating pyproject.toml and osv-scanner.toml ahead of the Starbase merge.
76%
#597 feat: format toml files with tombi starbase closed Merged as commit 79fa93c, adding tombi-based TOML formatting and [tool.tombi] configuration in pyproject.toml; closes #437.
70%