← Back to issue list

style: format pyproject.toml with tombi

View original Github issue

Metadata

Project
craft-application
Number
#1213
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR applying tombi formatting to pyproject.toml (2-space indent, canonical key ordering), decoupling the mechanical diff from the upcoming Starbase sync.

Resolution: closed resolved

Reason: PR #1213 was merged after approval, applying standard tombi formatting to pyproject.toml as preparation for the Starbase sync.

Evaluated by: mr-cal-bot

No scores available.

Issue body

🤖 This is a preparation PR for the Starbase sync, isolating the mechanical TOML formatting changes from the merge diff. ### Summary - Applies standard `tombi` formatting (2-space indent, canonical key ordering) to `pyproject.toml`. - Decouples the mechanical 600+ line diff from the upcoming Starbase sync merge. Provenance: - Starbase PR: [canonical/starbase#597](https://github.com/canonical/starbase/pull/597)

Evaluation history

Date Model Scores Action Summary
~deepseek/deepseek-pro-latest — closed resolved Merged PR applying tombi formatting to pyproject.toml (2-space indent, canonical key ordering), decoupling the mechanical diff from the upcoming Starbase sync.
~deepseek/deepseek-pro-latest
Impact: 10
Quick Win: 6
Complexity: 15
Confidence: 70
Actionability: 70
needs review Mechanical tombi formatting of pyproject.toml (2-space indent, canonical key ordering), decoupling the 600+ line diff from the upcoming Starbase sync. Approved with one unresolved review comment; snap-tests (openstack) failing.
~deepseek/deepseek-pro-latest
Impact: 15
Quick Win: 9
Complexity: 20
Confidence: 85
Actionability: 75
needs review Mechanical tombi reformatting of pyproject.toml (2-space indent, canonical key ordering) to isolate the diff from the upcoming Starbase sync. Approved, CI green, one unresolved review comment.
~deepseek/deepseek-pro-latest
Impact: 20
Quick Win: 10
Complexity: 35
Confidence: 88
Actionability: 80
needs review Mechanical tombi reformatting of pyproject.toml (2-space indent, canonical key ordering) to isolate the 600+ line diff from the upcoming Starbase sync. CI green, no reviewers yet.
~deepseek/deepseek-pro-latest
Impact: 10
Quick Win: 7
Complexity: 15
Confidence: 88
Actionability: 85
needs review Formats pyproject.toml with tombi (2-space indent, canonical key ordering), isolating the mechanical 600+ line diff from the Starbase sync. CI green, awaiting review.
~deepseek/deepseek-pro-latest
Impact: 15
Quick Win: 9
Complexity: 25
Confidence: 85
Actionability: 80
needs review Mechanical tombi reformatting of pyproject.toml (2-space indent, canonical key ordering) ahead of Starbase sync; 632-line diff, CI passing, awaiting review.

Update history

Date Change
merged
updated
updated
updated
updated
created

Related work

  • Related To: canonical/starbase#597 (confidence 90%)

    Preparation PR isolating the mechanical TOML formatting changes from the Starbase sync merge.

Related issues

Issue Project State Summary Similarity
#200 style: format pyproject.toml with tombi debcraft merged Merged a mechanical reformat of pyproject.toml using tombi for indentation, quoting, and key ordering, preparing for the Starbase sync.
96%
#506 style: format pyproject.toml with tombi craft-cli merged Merged PR #506 mechanically reformats pyproject.toml with tombi to align with Starbase build tooling, containing no functional changes.
94%
#277 style: format pyproject.toml with tombi craft-platforms closed Merged as commit 14d9828, mechanically formatting pyproject.toml with tombi; the change was also folded into the Starbase update in #270.
93%
#218 style: format pyproject.toml with tombi craft-grammar merged Merged PR formatting pyproject.toml with tombi to align with Starbase make format and make lint rules. Purely mechanical style changes.
92%
#451 style: format TOML files with tombi imagecraft closed Merged TOML formatting with tombi in squash commit 705d996, updating pyproject.toml and osv-scanner.toml ahead of the Starbase merge.
86%
#435 chore: format pyproject.toml with tombi craft-store merged Merged PR formatting pyproject.toml with tombi for consistent TOML formatting ahead of starbasification.
84%
#2894 chore: format pyproject.toml with tombi ahead of Starbase merge charmcraft closed Superseded by #2898, which reapplied the tombi formatting and merged as f1af0486 ahead of the Starbase update in #2899.
81%
#597 feat: format toml files with tombi starbase closed Merged as commit 79fa93c, adding tombi-based TOML formatting and [tool.tombi] configuration in pyproject.toml; closes #437.
80%
#436 chore: format pyproject.toml with tombi craft-store closed PR #436 was superseded by merged PR #435 (commit fe67242) which applied the same tombi formatting to pyproject.toml.
78%
#2898 chore: format pyproject.toml with tombi ahead of Starbase merge charmcraft closed Closed unmerged after its prep branch was dropped during the Starbase update; replacement PR #2899 merged as commit 8da01822.
76%