← Back to issue list

chore: remove unused constants from const.py

View original Github issue

Metadata

Project
charmcraft
Number
#2916
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Removes 9 unused constants from charmcraft/const.py. Superseded by merged PR #2965 which recreated this work.

Suggested action: close superseded

Reason: PR #2965 (merged) recreated the work from #2916 to remove the same unused constants from const.py. The issue summary for #2965 explicitly states it 'recreated the work from #2916', making #2916 a superseded duplicate.

Evaluated by: mr-cal-bot

Impact: 5 Quick Win: 0 Complexity: 5 Confidence: 95 Actionability: 0

Issue body

Removes 9 module-level constants in `charmcraft/const.py` that have no references anywhere in the repository (verified by grep across `charmcraft/`, `tests/`, `docs/`, and config files): - `DEVELOPER_MODE_ENV_VAR` - `PROVIDER_ENV_VAR` - `WORK_DIRNAME` - `SUPPORTED_OSES` - `UBUNTU_LTS_STABLE` - `METADATA_YAML_KEYS` - `CHARM_METADATA_LEGARY_KEYS_ALIAS` (also a typo: LEGARY) - `CHARM_METADATA_KEYS` - `CHARM_METADATA_KEYS_ALIAS` Part of a series removing dead code found in a repository-wide audit.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b
Impact: 5
Quick Win: 0
Complexity: 5
Confidence: 95
Actionability: 0
close superseded Removes 9 unused constants from charmcraft/const.py. Superseded by merged PR #2965 which recreated this work.
~deepseek/deepseek-pro-latest
Impact: 10
Quick Win: 8
Complexity: 5
Confidence: 90
Actionability: 80
needs review Removes 9 unused module-level constants from charmcraft/const.py, verified to have no references elsewhere in the repo; awaiting review.
~deepseek/deepseek-pro-latest
Impact: 15
Quick Win: 10
Complexity: 5
Confidence: 80
Actionability: 70
needs review Removes 9 unused module-level constants from charmcraft/const.py as part of a dead-code audit; +0/-73 lines, pending review.

Update history

Date Change
updated
created

Related work

  • Superseded By: charmcraft#2965 (confidence 95%)

    Merged PR that recreated the same change from #2916.

Related issues

Issue Project State Summary Similarity
#2965 chore: remove unused constants from const.py charmcraft merged Merged PR #2965 to remove unused constants from `const.py`, recreating the work from #2916.
89%
#2920 chore: remove unused _global_args attribute charmcraft open PR #2920 removes unused _global_args attribute from Charmcraft class. Superseded by merged PR #2962 which recreates the same changes.
76%
#2917 chore: remove unused KNOWN_GOOD_PIP_HASH constant charmcraft merged Merged PR #2917 removing unused KNOWN_GOOD_PIP_HASH constant from charmcraft/charm_builder.py; dead code with no repository references.
76%
#2918 chore: remove unused RelativePath alias charmcraft open Removes unused RelativePath alias from charmcraft/models/basic.py. Superseded by merged PR #2964.
71%