← Back to issue list

chore: remove unused RelativePath alias

View original Github issue

Metadata

Project
charmcraft
Number
#2918
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Removes unused RelativePath alias from charmcraft/models/basic.py. Superseded by merged PR #2964.

Suggested action: close superseded

Reason: PR #2964 has already been merged and implements the same change (removing the unused RelativePath alias). The current file charmcraft/models/basic.py confirms the alias is already gone.

Evaluated by: mr-cal-bot

Impact: 5 Quick Win: 5 Complexity: 5 Confidence: 100 Actionability: 100

Issue body

Removes the `RelativePath = craft_parts.constraints.RelativePathStr` alias (and its now-unused import) from `charmcraft/models/basic.py`, which has no references anywhere in the repository (verified by grep). Part of a series removing dead code found in a repository-wide audit.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b
Impact: 5
Quick Win: 5
Complexity: 5
Confidence: 100
Actionability: 100
close superseded Removes unused RelativePath alias from charmcraft/models/basic.py. Superseded by merged PR #2964.
~deepseek/deepseek-pro-latest
Impact: 5
Quick Win: 4
Complexity: 2
Confidence: 95
Actionability: 88
needs review Removes unused RelativePath alias and its craft_parts.constraints import from charmcraft/models/basic.py; no references remain in the repo.

Update history

Date Change
created

Related work

  • Superseded By: charmcraft#2964 (confidence 100%)

    PR #2964 merged the same change, described as 'recreating #2918'.

Related issues

Issue Project State Summary Similarity
#2964 chore: remove unused RelativePath alias charmcraft merged Merged PR removing the unused RelativePath alias and its import, recreating #2918.
87%
#2920 chore: remove unused _global_args attribute charmcraft open PR #2920 removes unused _global_args attribute from Charmcraft class. Superseded by merged PR #2962 which recreates the same changes.
74%
#2916 chore: remove unused constants from const.py charmcraft open Removes 9 unused constants from charmcraft/const.py. Superseded by merged PR #2965 which recreated this work.
71%
#2917 chore: remove unused KNOWN_GOOD_PIP_HASH constant charmcraft merged Merged PR #2917 removing unused KNOWN_GOOD_PIP_HASH constant from charmcraft/charm_builder.py; dead code with no repository references.
70%