chore: remove unused _global_args attribute
Metadata
Current evaluation
PR #2920 removes unused _global_args attribute from Charmcraft class. Superseded by merged PR #2962 which recreates the same changes.
Suggested action: close superseded
Reason: PR #2962 has already been merged and its summary explicitly states it 'recreates the changes from #2920'. This PR is therefore superseded by the merged PR #2962.
Evaluated by: mr-cal-bot
Impact:
5
Quick Win:
0
Complexity:
5
Confidence:
95
Actionability:
10
Issue body
Removes the `_global_args` attribute from `Charmcraft` in `charmcraft/application/main.py`. It was set in `configure()` but never read anywhere (the parent class uses `_global_arguments` instead). Verified by grep across the repository. Part of a series removing dead code found in a repository-wide audit.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
5
Quick Win:
0
Complexity:
5
Confidence:
95
Actionability:
10
|
close superseded | PR #2920 removes unused _global_args attribute from Charmcraft class. Superseded by merged PR #2962 which recreates the same changes. | |
| qwen/qwen3.6-35b-a3b |
Impact:
5
Quick Win:
5
Complexity:
5
Confidence:
100
Actionability:
100
|
close superseded | Removes unused _global_args attribute from Charmcraft class. Superseded by merged PR #2962 which recreates these changes. | |
| ~deepseek/deepseek-pro-latest |
Impact:
10
Quick Win:
6
Complexity:
5
Confidence:
75
Actionability:
65
|
needs review | Removes the unused `_global_args` attribute from `Charmcraft` (set in `configure()` but never read; parent uses `_global_arguments`). Clean 2-line diff, but `lint / files` and OSV-scanner CI checks are failing. | |
| ~deepseek/deepseek-pro-latest |
Impact:
8
Quick Win:
7
Complexity:
2
Confidence:
95
Actionability:
85
|
needs review | Removes unused _global_args attribute from Charmcraft in charmcraft/application/main.py; set in configure() but never read. Dead code cleanup, awaiting review. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Superseded By:
charmcraft#2962
(confidence 95%)
PR #2962 was merged and its summary confirms it recreates the changes from #2920.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2962 chore: remove unused _global_args attribute | charmcraft | merged | Merged PR #2962 removes the unused `_global_args` attribute, recreating the changes from #2920. | |
| #2916 chore: remove unused constants from const.py | charmcraft | open | Removes 9 unused constants from charmcraft/const.py. Superseded by merged PR #2965 which recreated this work. | |
| #2918 chore: remove unused RelativePath alias | charmcraft | open | Removes unused RelativePath alias from charmcraft/models/basic.py. Superseded by merged PR #2964. | |
| #2917 chore: remove unused KNOWN_GOOD_PIP_HASH constant | charmcraft | merged | Merged PR #2917 removing unused KNOWN_GOOD_PIP_HASH constant from charmcraft/charm_builder.py; dead code with no repository references. | |
| #1765 chore: remove classic entrypoint | charmcraft | merged | Merged charmcraft#1765 as commit ffca2b8e, removing the obsolete classic entrypoint left over from the craft-application migration. |