← Back to issue list

chore: remove unused KNOWN_GOOD_PIP_HASH constant

View original Github issue

Metadata

Project
charmcraft
Number
#2917
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2917 removing unused KNOWN_GOOD_PIP_HASH constant from charmcraft/charm_builder.py; dead code with no repository references.

Resolution: closed resolved

Reason: PR #2917 was merged after approval by two reviewers, removing the unused constant with no references anywhere in the repository.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Removes `KNOWN_GOOD_PIP_HASH` from `charmcraft/charm_builder.py`, which has no references anywhere in the repository (verified by grep). Part of a series removing dead code found in a repository-wide audit.

Evaluation history

Date Model Scores Action Summary
~deepseek/deepseek-pro-latest — closed resolved Merged PR #2917 removing unused KNOWN_GOOD_PIP_HASH constant from charmcraft/charm_builder.py; dead code with no repository references.
~deepseek/deepseek-pro-latest
Impact: 5
Quick Win: 5
Complexity: 2
Confidence: 95
Actionability: 95
needs review Removes the unused KNOWN_GOOD_PIP_HASH constant from charmcraft/charm_builder.py; dead code with no references. Approved by 2 reviewers, no unresolved comments.
~deepseek/deepseek-pro-latest
Impact: 5
Quick Win: 5
Complexity: 2
Confidence: 95
Actionability: 95
needs review Removes unused KNOWN_GOOD_PIP_HASH constant from charmcraft/charm_builder.py; approved by one reviewer with no unresolved comments, awaiting merge.
~deepseek/deepseek-pro-latest
Impact: 5
Quick Win: 4
Complexity: 3
Confidence: 95
Actionability: 80
needs review Removes unused KNOWN_GOOD_PIP_HASH constant from charmcraft/charm_builder.py; grep confirms no other references. Clean 3-line deletion awaiting review.

Update history

Date Change
merged
updated
updated
updated
created

Related work

  • Related To: canonical/charmcraft#1716 (confidence 75%)

    Commit def89c50 from PR #1716 likely introduced the KNOWN_GOOD_PIP_HASH constant later removed by #2917.

Related issues

Issue Project State Summary Similarity
#2916 chore: remove unused constants from const.py charmcraft open Removes 9 unused constants from charmcraft/const.py. Superseded by merged PR #2965 which recreated this work.
76%
#2920 chore: remove unused _global_args attribute charmcraft open PR #2920 removes unused _global_args attribute from Charmcraft class. Superseded by merged PR #2962 which recreates the same changes.
74%
#2918 chore: remove unused RelativePath alias charmcraft open Removes unused RelativePath alias from charmcraft/models/basic.py. Superseded by merged PR #2964.
70%