← Back to issue list

The control of `bases` in `charmcraft.yaml` should be different for bundles

View original Github issue

Metadata

Project
charmcraft
Number
#479
Type
issue
State
closed
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Fixed by merged PR #545: bundles no longer warn when bases is omitted, and bundle configurations declaring bases are rejected.

Resolution: closed resolved

Reason: Merged PR canonical/charmcraft#545 fixed #479 by removing the missing-bases warning for bundles and forbidding bases in bundle configurations.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Currently it complains that there's no `bases`: ``` $ charmcraft revisions facutest-bundle-1 DEPRECATED: Bases configuration is now required. See https://discourse.charmhub.io/t/4652#heading--dn03 for more information. Revision Version Created at Status 1 1 2021-02-03 released ``` But bundles do NOT have bases. So this check should be removed. And ANOTHER check should be implemented, to actually error out if the bundle's config has `bases` included (to avoid confusions). Thanks!

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by merged PR #545: bundles no longer warn when bases is omitted, and bundle configurations declaring bases are rejected.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR #545: bundles no longer warn when bases is omitted, and declaring bases in bundle configuration is forbidden.
qwen3.6-35b-a3b-mtp-q6 — — Closed without resolution. The request to adjust bases validation for bundles was abandoned due to inactivity. No comments or follow-up actions were recorded.
qwen/qwen3.6-35b-a3b — — Abandoned. The requested removal of the mandatory bases check for bundles and addition of a validation error for explicit bases in bundle configs was not implemented.
qwen/qwen3.6-35b-a3b — — Requesting relaxed bases validation for bundles was closed without resolution. No fix was implemented, leaving charmcraft to incorrectly flag bundle configurations as missing required bases.
qwen/qwen3.6-35b-a3b — — Abandoned due to inactivity. The request to remove the mandatory bases check for bundles and add validation to reject bases in bundle configs was not implemented.
qwen3.6-35b-a3b-mtp-q6 — — Abandoned due to inactivity. The request to adjust bases validation for bundles was closed without implementation, leaving the warning check unchanged.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#545 (confidence 100%)

    Merged PR implementing both requested bundle-specific bases checks.

Related issues

Issue Project State Summary Similarity
#545 For bundles, do not show a deprecation message if 'bases' not included, and forbid its usage. charmcraft merged Merged PR #545 fixed #479: bundles no longer warn when bases is omitted, and bundle configurations specifying bases are rejected.
74%
#383 commands/build: charm file name format support for bases (CRAFT-66) charmcraft merged Merged PR #383 (commit 951f6aaa; merge 1c839909) added bases-aware charm filename formatting and tests, retaining the legacy runtime path pending default-bases configuration.
73%
#1795 fix(package): Limit the bases in manifest.yaml charmcraft merged Merged #1795 in commit 8b16cae4, limiting manifest.yaml bases for bases charms to those used by the current build instead of all run bases.
73%
#299 [WIP] charmcraft config: introduce support for bases keyword charmcraft closed Abandoned WIP; bases support landed separately through merged PRs #339 (9af3b121) and #341 (b76170f9), covering long- and short-form configurations.
72%
#411 build: pack charm in provided environment when using bases (CRAFT-313) charmcraft merged Merged PR #411 (CRAFT-313) to pack each viable bases configuration in its provided build environment; merge commit 523c6fb0.
70%