providers: introduce get_command_environment() to build env (CRAFT-262)
Metadata
Current evaluation
Merged PR #406 introduced provider command-environment construction, adding managed-mode and proxy variables; merged as commit 6e793e4d.
Resolution: closed resolved
Reason: PR #406 was approved with no unresolved review comments and merged. Its change added get_command_environment() with CHARMCRAFT_MANAGED_MODE and applicable proxy settings, resolving CRAFT-262.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Add get_command_environment() method to build and return the command
environment to use when executing commands in the provided container.
Starting with the default buildd environment, add:
- CHARMCRAFT_MANAGED_MODE=1
- [http|https|no]_proxy settings if found in current Charmcraft process.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #406 introduced provider command-environment construction, adding managed-mode and proxy variables; merged as commit 6e793e4d. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #406 introduced get_command_environment() for container commands, adding managed-mode and inherited proxy settings via merge commit 6e793e4d. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #406 introduced get_command_environment(), adding CHARMCRAFT_MANAGED_MODE and proxy variables to container command environments; merge commit 6e793e4d. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged PR introducing get_command_environment() to build container command environments with CHARMCRAFT_MANAGED_MODE=1 and proxy settings. Added a reviewer-requested test filtering random environment variables. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds get_command_environment() to build container command environments, injecting CHARMCRAFT_MANAGED_MODE=1 and proxy settings. A requested test excluding random environment variables was added prior to merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #882 (internal) Move get_command_environment() to providers.py (CRAFT-1354) | charmcraft | merged | Merged PR #882, moving get_command_environment() into providers.py and updating callers; commit 0149345c was merged by d388fd4f. | |
| #3927 providers: move `get_command_environment()` to providers.py | snapcraft | merged | Merged PR #3927 moved Snapcraft's get_command_environment() from the craft-providers interface to providers.py, resolving CRAFT-1352 in commit 917d5e76a. | |
| #75 providers: move get_command_environment() to providers.py | rockcraft | merged | Merged PR #75 (d81ce59d) relocated Rockcraft-specific get_command_environment() to providers.py for CRAFT-1353. |