← Back to issue list

providers: move get_command_environment() to providers.py

View original Github issue

Metadata

Project
rockcraft
Number
#75
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #75 (d81ce59d) relocated Rockcraft-specific get_command_environment() to providers.py for CRAFT-1353.

Resolution: closed resolved

Reason: PR #75 was merged into the project as commit d81ce59d, completing the CRAFT-1353 refactor.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- `get_command_environment()` is a rockcraft-specific function, so it is moved to providers.py (CRAFT-1353)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #75 (d81ce59d) relocated Rockcraft-specific get_command_environment() to providers.py for CRAFT-1353.
stealth/space-bunny-alpha — closed resolved Merged PR #75 (d81ce59d), relocating rockcraft-specific get_command_environment() to providers.py as part of CRAFT-1353.
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI checks. The rockcraft-specific get_command_environment() function was relocated to providers.py across eight files, improving module organization and reducing duplication.
qwen3.6-35b-a3b-mtp-q6 — — Merged the refactoring that relocates the rockcraft-specific get_command_environment() function to providers.py, resolving CRAFT-1353.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#882 (internal) Move get_command_environment() to providers.py (CRAFT-1354) charmcraft merged Merged PR #882, moving get_command_environment() into providers.py and updating callers; commit 0149345c was merged by d388fd4f.
90%
#3927 providers: move `get_command_environment()` to providers.py snapcraft merged Merged PR #3927 moved Snapcraft's get_command_environment() from the craft-providers interface to providers.py, resolving CRAFT-1352 in commit 917d5e76a.
87%
#406 providers: introduce get_command_environment() to build env (CRAFT-262) charmcraft merged Merged PR #406 introduced provider command-environment construction, adding managed-mode and proxy variables; merged as commit 6e793e4d.
75%
#3940 providers: move `get_provider()` to providers.py snapcraft merged Merged PR #3940 by mr-cal moved get_provider() into snapcraft/providers.py (squash commit 2acdd89b6), a CRAFT-1409 refactor mirroring canonical/rockcraft#92, part of a series of provider/lifecycle function moves.
71%
#898 providers: move `get_provider()` to providers.py charmcraft merged Merged charmcraft#898, moving get_provider() into providers.py for CRAFT-1410 after prerequisite charmcraft#896 landed.
71%