← Back to issue list

providers: move get_command_environment() to providers.py

View original Github issue

Metadata

Project
rockcraft
Number
#75
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged after approval and passing CI checks. The rockcraft-specific get_command_environment() function was relocated to providers.py across eight files, improving module organization and reducing duplication.

Suggested action: —

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- `get_command_environment()` is a rockcraft-specific function, so it is moved to providers.py (CRAFT-1353)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI checks. The rockcraft-specific get_command_environment() function was relocated to providers.py across eight files, improving module organization and reducing duplication.
qwen3.6-35b-a3b-mtp-q6 — — Merged the refactoring that relocates the rockcraft-specific get_command_environment() function to providers.py, resolving CRAFT-1353.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Relocated the rockcraft-specific get_command_environment() function to providers.py to centralize provider logic, resolving CRAFT-1353.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#882 (internal) Move get_command_environment() to providers.py (CRAFT-1354) charmcraft merged Merged internal refactoring that relocated the get_command_environment() function to providers.py. Approved by one reviewer, passed CI checks, and modified eight files with a net reduction of 60 lines.
84%
#3927 providers: move `get_command_environment()` to providers.py snapcraft merged Merged pull request moving the snapcraft-specific get_command_environment() function out of the craft-providers interface and into providers.py. Approved, passed CI checks, and achieved 100% coverage.
81%
#3940 providers: move `get_provider()` to providers.py snapcraft merged Merged the refactoring that moves get_provider() to providers.py. Aligned with rockcraft, the change passed code review and CI checks, modified 7 files, and was successfully integrated into main.
72%