← Back to issue list

(internal) Move get_command_environment() to providers.py (CRAFT-1354)

View original Github issue

Metadata

Project
charmcraft
Number
#882
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #882, moving get_command_environment() into providers.py and updating callers; commit 0149345c was merged by d388fd4f.

Resolution: closed resolved

Reason: PR #882 was approved and merged into the default branch as d388fd4f. It completed CRAFT-1354 by relocating the helper and updating eight files.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #882, moving get_command_environment() into providers.py and updating callers; commit 0149345c was merged by d388fd4f.
stealth/space-bunny-alpha — closed resolved Merged PR #882 for CRAFT-1354, relocating get_command_environment() to providers.py and updating eight files, with a net reduction of 60 lines.
qwen/qwen3.6-35b-a3b — — Merged internal refactoring that relocated the get_command_environment() function to providers.py. Approved by one reviewer, passed CI checks, and modified eight files with a net reduction of 60 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged pull request moving get_command_environment() to providers.py (CRAFT-1354) by facundobatista.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#406 (confidence 96%)

    Earlier PR that introduced get_command_environment(), which #882 later relocated.

Related issues

Issue Project State Summary Similarity
#75 providers: move get_command_environment() to providers.py rockcraft merged Merged PR #75 (d81ce59d) relocated Rockcraft-specific get_command_environment() to providers.py for CRAFT-1353.
90%
#3927 providers: move `get_command_environment()` to providers.py snapcraft merged Merged PR #3927 moved Snapcraft's get_command_environment() from the craft-providers interface to providers.py, resolving CRAFT-1352 in commit 917d5e76a.
89%
#406 providers: introduce get_command_environment() to build env (CRAFT-262) charmcraft merged Merged PR #406 introduced provider command-environment construction, adding managed-mode and proxy variables; merged as commit 6e793e4d.
77%