← Back to issue list

(internal) Move get_command_environment() to providers.py (CRAFT-1354)

View original Github issue

Metadata

Project
charmcraft
Number
#882
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged internal refactoring that relocated the get_command_environment() function to providers.py. Approved by one reviewer, passed CI checks, and modified eight files with a net reduction of 60 lines.

Suggested action: —

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged internal refactoring that relocated the get_command_environment() function to providers.py. Approved by one reviewer, passed CI checks, and modified eight files with a net reduction of 60 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged pull request moving get_command_environment() to providers.py (CRAFT-1354) by facundobatista.
qwen3.6-35b-a3b-mtp-q6 — — Merged internal refactoring that relocates get_command_environment() to providers.py, resolving CRAFT-1354. The change was integrated by maintainer facundobatista without additional review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#75 providers: move get_command_environment() to providers.py rockcraft merged Merged after approval and passing CI checks. The rockcraft-specific get_command_environment() function was relocated to providers.py across eight files, improving module organization and reducing duplication.
84%
#3927 providers: move `get_command_environment()` to providers.py snapcraft merged Merged pull request moving the snapcraft-specific get_command_environment() function out of the craft-providers interface and into providers.py. Approved, passed CI checks, and achieved 100% coverage.
83%
#406 providers: introduce get_command_environment() to build env (CRAFT-262) charmcraft merged Merged PR introducing get_command_environment() to build container command environments with CHARMCRAFT_MANAGED_MODE=1 and proxy settings. Added a reviewer-requested test filtering random environment variables. Approved and passed CI.
70%