providers: move `get_command_environment()` to providers.py
Metadata
Current evaluation
Merged PR #3927 moved Snapcraft's get_command_environment() from the craft-providers interface to providers.py, resolving CRAFT-1352 in commit 917d5e76a.
Resolution: closed resolved
Reason: PR snapcore/snapcraft#3927 was merged, relocating the Snapcraft-specific environment helper to providers.py in commit 917d5e76a.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
`get_command_environment()` is a snapcraft-specific call, so it is moved out of the craft-providers interface.
Similar to https://github.com/canonical/rockcraft/pull/75
(CRAFT-1352)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3927 moved Snapcraft's get_command_environment() from the craft-providers interface to providers.py, resolving CRAFT-1352 in commit 917d5e76a. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR snapcore/snapcraft#3927 (commit 917d5e76a) relocated the snapcraft-specific get_command_environment() out of the craft-providers interface into snapcraft/providers.py, mirroring canonical/rockcraft#75. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3927 moved the Snapcraft-specific get_command_environment() helper from the craft-providers interface into providers.py. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3927 (CRAFT-1352), moving the Snapcraft-specific get_command_environment() function from the craft-providers interface to providers.py. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request moving the snapcraft-specific get_command_environment() function out of the craft-providers interface and into providers.py. Approved, passed CI checks, and achieved 100% coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Relocated the snapcraft-specific get_command_environment() function from the craft-providers interface to providers.py, matching rockcraft refactoring. Achieved 100% diff coverage and resolves CRAFT-1352. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/rockcraft#75
(confidence 98%)
Explicitly cited as the analogous Rockcraft change, merged as commit d81ce59d.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #882 (internal) Move get_command_environment() to providers.py (CRAFT-1354) | charmcraft | merged | Merged PR #882, moving get_command_environment() into providers.py and updating callers; commit 0149345c was merged by d388fd4f. | |
| #75 providers: move get_command_environment() to providers.py | rockcraft | merged | Merged PR #75 (d81ce59d) relocated Rockcraft-specific get_command_environment() to providers.py for CRAFT-1353. | |
| #406 providers: introduce get_command_environment() to build env (CRAFT-262) | charmcraft | merged | Merged PR #406 introduced provider command-environment construction, adding managed-mode and proxy variables; merged as commit 6e793e4d. | |
| #3940 providers: move `get_provider()` to providers.py | snapcraft | merged | Merged PR #3940 by mr-cal moved get_provider() into snapcraft/providers.py (squash commit 2acdd89b6), a CRAFT-1409 refactor mirroring canonical/rockcraft#92, part of a series of provider/lifecycle function moves. |