← Back to issue list

providers: move `get_instance_name()` call to lifecycle.py

View original Github issue

Metadata

Project
rockcraft
Number
#80
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged. Moved the rockcraft-specific get_instance_name() call from provider classes to lifecycle.py to separate application-specific logic. Approved by reviewer, CI passed, spanning 6 files with 57 additions and 34 deletions.

Suggested action: —

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Another bite-sized chunk of separating application-specific logic out of the `Provider` classes. `get_instance_name()` is a rockcraft-specific function, so it is now called from `lifecycle.py`. (CRAFT-1379)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged. Moved the rockcraft-specific get_instance_name() call from provider classes to lifecycle.py to separate application-specific logic. Approved by reviewer, CI passed, spanning 6 files with 57 additions and 34 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Moved the get_instance_name() call from Provider classes to lifecycle.py to separate application-specific logic. Resolves CRAFT-1379.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Moved the rockcraft-specific get_instance_name() call from Provider classes to lifecycle.py to separate application-specific logic from generic provider implementations. Resolves CRAFT-1379.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#74 providers: move get_instance_name() to providers.py rockcraft merged Merged after approval and passing CI. Moved the rockcraft-specific get_instance_name() function to providers.py, changing 8 files. Resolves CRAFT-1350.
85%
#3940 providers: move `get_provider()` to providers.py snapcraft merged Merged the refactoring that moves get_provider() to providers.py. Aligned with rockcraft, the change passed code review and CI checks, modified 7 files, and was successfully integrated into main.
75%
#3926 providers: move `get_instance_name()` to providers.py snapcraft merged Merged. Moved get_instance_name() to snapcraft/providers/providers.py, removing snapcraft-specific logic from provider modules. This refactoring prepares the codebase for the new craft-providers API. Approved by reviewers and passed all CI checks.
74%
#82 providers: move mount logic to lifecycle.py rockcraft merged Merged. Moved project directory mount logic from craft-providers to rockcraft's lifecycle.py, as it is rockcraft-specific. Approved, passed CI, and modified six files with a net reduction of 13 lines.
73%
#110 providers: move lxd project name out of craft-providers interface rockcraft merged Merged refactoring that moves rockcraft's project name from lxd.py to providers.py in the craft-providers interface. Approved by one reviewer, passed CI, and successfully integrated.
72%
#885 (internal) Moved get_instance_name functionality to providers helper (CRAFT-1304). charmcraft merged Merged refactoring moving get_instance_name to a providers helper, resolving CRAFT-1304. Approved by one reviewer with no unresolved comments, spanning eight files with a net reduction of 49 lines.
71%