refactor: make rockcraft-pack follow new call conventions
Metadata
Current evaluation
Merged PR #73 (bepri): refactored rockcraft-pack into new call conventions — per-tool actions at <tool>/<action>, tests/dists alongside actions, shared behaviour moved from _common/ to common/, mirroring canonical/starflow#155.
Resolution: closed resolved
Reason: PR #73 was merged after approval from 2 reviewers with all CI checks passing (run-rockcraft-pack-action on ubuntu-22.04/24.04, legacy rock, test-action-code). The refactor restructured the repo layout (+389/-233, 17 files) with no failing checks.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR moves towards the ideal project structure moving forward. It mirrors the conventions being added in https://github.com/canonical/starflow/pull/155.
- Each tool's actions will be contained in `<tool>/<action>`
- Tests and dists live alongside their action
- Shared behaviors live in `common/` (this will replace `_common/` once the composite actions are gone)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #73 (bepri): refactored rockcraft-pack into new call conventions — per-tool actions at <tool>/<action>, tests/dists alongside actions, shared behaviour moved from _common/ to common/, mirroring canonical/starflow#155. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/craft-actions#73 refactors rockcraft-pack to the new call conventions: actions under <tool>/<action>, tests and dists alongside actions, and shared behaviours moved to common/ (replacing _common/). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-actions#73 after approval and passing CI; refactored rockcraft-pack to organize actions, tests, and shared behaviors using the new directory conventions. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approvals and CI. Refactored rockcraft-pack to adopt new conventions: actions in dedicated directories, tests co-located, shared logic in common/. Updated 17 files. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
5
Complexity:
25
Confidence:
85
|
needs review | Refactors rockcraft-pack directory structure to align with new project conventions, moving actions, tests, and shared code into a standardized layout. Currently unreviewed and freshly opened. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/starflow#155
(confidence 80%)
PR body states this refactor mirrors the new call conventions being added in canonical/starflow#155.
-
Related To:
canonical/craft-actions#1
(confidence 70%)
Merged PR #1 introduced rockcraft-pack and the original _common/ layout that #73 restructures into common/.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #61 refactor: make shareable components abstract | craft-actions | merged | Merged in canonical/craft-actions#61 as commit 43e7369, extracting reusable Rockcraft pack components into common modules for future Node-based Craft Actions. | |
| #354 refactor: use craft-application for "pack" | rockcraft | merged | Merged #354 routed rockcraft pack through the CraftApplication runner (commit 8d74e452); its feature branch was later integrated into main by #395. | |
| #1350 Move Rockcraft to the craft-application mediation framework | rockcraft | closed | Closed after ROCKCRAFT-319 was filed; no PR linked. Related commit 0b6ba8bd (PR #1357, 'skip repacking if project is unchanged') implements the no-repack goal. | |
| #40 feat(rockcraft-pack): support rockcraft test | craft-actions | merged | Merged #40 as commit 05e3417, adding rockcraft test support to rockcraft-pack so test workflows can reuse the action's packed rock. | |
| #1 rockcraft-pack: new action initializing repository | craft-actions | merged | Merged canonical/craft-actions#1, bootstrapping the craft-actions repo with the first action, rockcraft-pack, for building ROCKs with Rockcraft inside GitHub Workflows (+16326/-33 lines, 21 files). |