refactor: make rockcraft-pack follow new call conventions
Metadata
Current evaluation
Merged after approvals and CI. Refactored rockcraft-pack to adopt new conventions: actions in dedicated directories, tests co-located, shared logic in common/. Updated 17 files.
Suggested action: —
No scores available.
Issue body
This PR moves towards the ideal project structure moving forward. It mirrors the conventions being added in https://github.com/canonical/starflow/pull/155.
- Each tool's actions will be contained in `<tool>/<action>`
- Tests and dists live alongside their action
- Shared behaviors live in `common/` (this will replace `_common/` once the composite actions are gone)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approvals and CI. Refactored rockcraft-pack to adopt new conventions: actions in dedicated directories, tests co-located, shared logic in common/. Updated 17 files. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
5
Complexity:
25
Confidence:
85
|
needs review | Refactors rockcraft-pack directory structure to align with new project conventions, moving actions, tests, and shared code into a standardized layout. Currently unreviewed and freshly opened. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #61 refactor: make shareable components abstract | craft-actions | merged | Merged after three approvals and passing CI checks. Refactored Rockcraft's pack action into abstract, shareable common modules to support future Node-based Craft Actions, modifying 13 files with a net code reduction. | |
| #354 refactor: use craft-application for "pack" | rockcraft | merged | Merged a refactor routing rockcraft pack to the new craft-application-based runner, resolving issue #316. The update spans 24 files with 935 additions and 40 deletions, received two approvals, and passed CI checks. | |
| #316 Rebase "rockcraft pack" onto craft-application framework | rockcraft | closed | Merged via PR #354 into a feature branch. The rockcraft pack command was rebased onto the craft-application framework to reduce code duplication across craft tools. | |
| #40 feat(rockcraft-pack): support rockcraft test | craft-actions | merged | Merged to integrate rockcraft test into the build workflow. The change handles implicit pack execution to avoid OCI Factory duplication. Approved by two reviewers, passed CI, and merged with 218 additions and 12 deletions. | |
| #1 rockcraft-pack: new action initializing repository | craft-actions | merged | Merged the rockcraft-pack GitHub Action for building ROCKs within workflows. Approved by two reviewers, the update adds 21 files and initializes the craft tools action collection. | |
| #8 project: add rockcraft.yaml load function (CRAFT-586) | rockcraft | merged | Merged after approval and passing CI checks. Extracts project file loading into a dedicated function with tests, modifying four files with 89 additions and 19 deletions. | |
| #715 refactor: use craft-platform for the build plans | rockcraft | merged | Merged refactor to use craft-platform for build plans, creating a single source for Rockcraft and remote builds. Approved by two reviewers, resolving issue #698 with 31 additions and 3 deletions across five files. | |
| #289 docs: expand rockcraft.yaml reference | rockcraft | merged | Merged after three reviewers approved, the PR reorganized the documentation reference section and expanded the rockcraft.yaml reference guide, modifying 7 files. | |
| #33 cli: Fix description of "rockcraft pack" | rockcraft | merged | Merged a one-line correction to the CLI help text for "rockcraft pack", updating the description to specify it packages a ROCK rather than a snap. Approved by two reviewers and passed CI. | |
| #395 refactor: merge feature/craft-application | rockcraft | merged | Merged feature/craft-application into main, completing Rockcraft's migration to craft-application 1.0.0. The refactoring modified 99 files, resolved multiple issues, and introduced breaking changes. Approved by two reviewers with passing CI. |