refactor: use craft-application for "pack"
Metadata
Current evaluation
Merged a refactor routing rockcraft pack to the new craft-application-based runner, resolving issue #316. The update spans 24 files with 935 additions and 40 deletions, received two approvals, and passed CI checks.
Suggested action: —
No scores available.
Issue body
This PR makes it so invocations of `rockcraft pack` get routed to the new craft-application-based "runner". This is a lot of code because "pack" basically needs everything that we do, but a lot of the code is copy/pasted from the now-legacy runner.
It is _strongly suggested_ to review per-commit
Fixes #316
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor routing rockcraft pack to the new craft-application-based runner, resolving issue #316. The update spans 24 files with 935 additions and 40 deletions, received two approvals, and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactor routing rockcraft pack to a new craft-application-based runner, fixing issue #316. The legacy runner was replaced with updated code following maintainer approval. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactor routing rockcraft pack to the new craft-application-based runner. Replaces legacy runner logic, fixes #316, and received maintainer approval after per-commit review. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #395 refactor: merge feature/craft-application | rockcraft | merged | Merged feature/craft-application into main, completing Rockcraft's migration to craft-application 1.0.0. The refactoring modified 99 files, resolved multiple issues, and introduced breaking changes. Approved by two reviewers with passing CI. | |
| #73 refactor: make rockcraft-pack follow new call conventions | craft-actions | merged | Merged after approvals and CI. Refactored rockcraft-pack to adopt new conventions: actions in dedicated directories, tests co-located, shared logic in common/. Updated 17 files. | |
| #316 Rebase "rockcraft pack" onto craft-application framework | rockcraft | closed | Merged via PR #354 into a feature branch. The rockcraft pack command was rebased onto the craft-application framework to reduce code duplication across craft tools. | |
| #856 refactor: use craft-application 5 | rockcraft | merged | Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed. | |
| #715 refactor: use craft-platform for the build plans | rockcraft | merged | Merged refactor to use craft-platform for build plans, creating a single source for Rockcraft and remote builds. Approved by two reviewers, resolving issue #698 with 31 additions and 3 deletions across five files. | |
| #61 refactor: make shareable components abstract | craft-actions | merged | Merged after three approvals and passing CI checks. Refactored Rockcraft's pack action into abstract, shareable common modules to support future Node-based Craft Actions, modifying 13 files with a net code reduction. | |
| #4682 refactor(app): use more code from craft-app | snapcraft | merged | Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines. | |
| #1704 craft-application migration cleanup: pack command | charmcraft | merged | Merged cleanup PR removing an outdated pack command retained for comparison during the craft-application migration. Approved by two reviewers with passing CI, the change deletes 1309 lines across six files. | |
| #521 refactor: port code to latest craft-app update | rockcraft | merged | Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines). | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests. |