refactor: use craft-application for "pack"
Metadata
Current evaluation
Merged #354 routed rockcraft pack through the CraftApplication runner (commit 8d74e452); its feature branch was later integrated into main by #395.
Resolution: closed resolved
Reason: PR #354 was approved and merged, introducing the CraftApplication-based pack runner in commit 8d74e452. PR #395 later integrated the feature branch into main, completing the migration.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR makes it so invocations of `rockcraft pack` get routed to the new craft-application-based "runner". This is a lot of code because "pack" basically needs everything that we do, but a lot of the code is copy/pasted from the now-legacy runner.
It is _strongly suggested_ to review per-commit
Fixes #316
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #354 routed rockcraft pack through the CraftApplication runner (commit 8d74e452); its feature branch was later integrated into main by #395. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #354 (commit 8d74e452 "feat: use CraftApplication for 'pack' command") routes `rockcraft pack` to a new craft-application-based runner, fixing #316; branch later finished by #395. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #354 routes rockcraft pack to a craft-application-based runner; its feature branch was later integrated by #395, completing migration to craft-application 1.0.0. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor routing rockcraft pack to the new craft-application-based runner, resolving issue #316. The update spans 24 files with 935 additions and 40 deletions, received two approvals, and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactor routing rockcraft pack to a new craft-application-based runner, fixing issue #316. The legacy runner was replaced with updated code following maintainer approval. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/rockcraft#316
(confidence 100%)
#354 explicitly fixes #316 by moving the pack command to CraftApplication.
-
Related To:
canonical/rockcraft#395
(confidence 99%)
#395 later merged the feature/craft-application branch into main.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #316 Rebase "rockcraft pack" onto craft-application framework | rockcraft | closed | Rebased rockcraft pack onto craft-application in PR #354 (8d74e452); PR #395 later merged feature/craft-application into main, completing the migration to craft-application 1.0.0. | |
| #856 refactor: use craft-application 5 | rockcraft | merged | Merged as commit 2139bcd2: refactored Rockcraft onto craft-application 5 (49 files, +959/-915) after approval from 3 reviewers; later bumped to craft-application 6.0 via #1027. | |
| #395 refactor: merge feature/craft-application | rockcraft | merged | Merged PR #395 into main, completing the breaking migration to craft-application 1.0.0 and resolving seven linked migration and command issues. | |
| #1350 Move Rockcraft to the craft-application mediation framework | rockcraft | closed | Closed after ROCKCRAFT-319 was filed; no PR linked. Related commit 0b6ba8bd (PR #1357, 'skip repacking if project is unchanged') implements the no-repack goal. | |
| #1275 feat: use craft-application for pack command | charmcraft | closed | Closed unmerged as superseded after a get_build_plan error. The broader craft-application migration landed in #1538 (5e3b927c), followed by pack-command cleanup in #1704 (cfc37020). | |
| #73 refactor: make rockcraft-pack follow new call conventions | craft-actions | merged | Merged PR #73 (bepri): refactored rockcraft-pack into new call conventions — per-tool actions at <tool>/<action>, tests/dists alongside actions, shared behaviour moved from _common/ to common/, mirroring canonical/starflow#155. | |
| #353 refactor(cli): add scaffolding for craft-application | rockcraft | merged | PR #353 merged into feature/craft-application as 5cff2f1c, adding craft-application scaffolding with a legacy-runner fallback. | |
| #1357 feat: skip repacking if project is unchanged | rockcraft | closed | PR #1357 by cmatsuoka merged as commit 0b6ba8bd, adopting the craft-application mediation API so Rockcraft skips repacking output artifacts when the project is unchanged. All checks passed. |