← Back to issue list

style: fix ty linting error

View original Github issue

Metadata

Project
craft-platforms
Number
#242
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce.

Resolution: closed resolved

Reason: The approved pull request corrected the linting failure and was merged into the main branch as commit e8b89ce.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-platforms#242, a one-line, single-file change that fixed the reported ty linting error.
qwen/qwen3.6-35b-a3b — — Merged a single-file change fixing a ty linting error. Approved by one reviewer and passed CI checks. The one-line modification resolves the style violation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#446 style(lint): fix typing for ty update craft-cli merged Merged PR #446 as commit 75ec620, updating typing for the ty linter and applying minor style fixes across three files.
84%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
84%
#1204 style: fix linting issues craft-parts closed Lint-only cleanup landed in commit a0622b31, matching PR #1204’s title; all reported CI checks passed.
79%
#5970 Fix `ty` warnings snapcraft closed Resolved all ty warnings via merged PRs #6015 (a36429c18) and #6027 (47bda5515); make lint-ty now runs cleanly.
78%
#1126 style: fix ty errors craft-application merged Merged PR #1126 (commit 9f5e0e76): small +8/-10 style fix taking advantage of ty's new Pydantic support, clearing remaining type-checker errors.
78%
#2222 style: fix linting issues charmcraft merged Merged PR #2222 as commit 31c109b4, applying style-only lint fixes across three files (+8/-9) with two approvals.
78%
#20 style: fix linting issues craft-artifacts merged Merged PR #20 via commit 04cbdc0, applying style-only lint fixes across four files (+11/-5); both reviews approved and all CI checks passed.
77%
#6280 style: ty 0.0.44 snapcraft merged Merged PR #6280 in commit 8b45efc80, applying ty 0.0.44 style updates after two approvals; unrelated CI failures did not block the merge.
77%
#885 style: enable type checking with ty craft-providers merged Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.
77%
#910 style: fix ty error craft-providers merged Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed.
76%