style: fix linting errors for ruff 0.12
Metadata
Current evaluation
PR #146 merged in craft-platforms (commit fdad4a1) to fix ruff 0.12 lint errors: added # noqa: PLC0415 to lazy import in tests/conftest.py and ignored PLW1641 (eq-without-hash) in pyproject.toml.
Resolution: closed resolved
Reason: The pull request was approved (2 reviewers, no unresolved comments) and merged as commit fdad4a1. Both changes it made are present at HEAD: a '# noqa: PLC0415' on the import in tests/conftest.py and a 'PLW1641' entry in the ruff ignore list in pyproject.toml, addressing ruff 0.12 promoting those rules to stable.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Ruff 0.12 made PLC0415 and PLW1641 stable. For PLW1641 this uncovered a bug (https://github.com/astral-sh/ruff/issues/18905), for PLC0415 we simply need to ignore it.
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #146 merged in craft-platforms (commit fdad4a1) to fix ruff 0.12 lint errors: added # noqa: PLC0415 to lazy import in tests/conftest.py and ignored PLW1641 (eq-without-hash) in pyproject.toml. | |
| qwen/qwen3.6-35b-a3b | — | closed resolved | Merged to fix linting errors for ruff 0.12, ignoring PLC0415 and addressing PLW1641 (which uncovered a ruff bug) |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Related To:
craft-platforms#408
(confidence 65%)
Later commit dc41fe4 'style: fix linting for ruff 0.12 (#408)' is a separate, subsequent ruff-0.12 lint change, not required to close #146.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #803 style: fix linting issues with ruff 0.12 | craft-application | merged | Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804. | |
| #173 style: fix lint for ruff 0.12 | craft-archives | merged | Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed. | |
| #1156 style: fix linting errors for ruff 0.12.0 | craft-parts | merged | Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed. | |
| #1737 style: fix linting for ruff 0.5 | charmcraft | merged | Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5. | |
| #907 style: adjust linting rules for ruff 0.12 | rockcraft | merged | Merged into main as 186cb0fb, updating Ruff 0.12 settings to ignore PLC0415 and avoid unnecessary noqa comments. | |
| #33 lint: fix lint issues with newer ruff | craft-archives | merged | PR #33 merged as commit c2a6687, fixing new lint failures introduced by a newer Ruff release across3 files (+5/-3). Maintainer deferred extra unit tests to CRAFT-1641. | |
| #19 style: fix linting issues for ruff 0.12 | craft-artifacts | closed | PR #19 was closed unmerged after prolonged inactivity; its Ruff 0.12 lint fixes were abandoned. Later PR #20 was merged as commit 04cbdc0. | |
| #580 style(ruff): fix linting issues from ruff update | craft-application | merged | Merged PR canonical/craft-application#580 (commit 97347705) by lengau applied style-only fixes (+7/-7, 3 files) for new lint failures caused by a Ruff update; approved by 3 reviewers. | |
| #408 style: fix linting for ruff 0.12 | starbase | merged | Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12. | |
| #901 style: fix ruff 0.13 linting issues | craft-application | merged | Merged in canonical/craft-application#901 via commit 0a659742, fixing Ruff 0.13 linting with a one-line change; review was approved and all CI checks passed. |