build!: update to pydantic 2
Metadata
Current evaluation
Merged PR #401 as commit c2f0978a, migrating craft-application to Pydantic 2 across 23 files; craft-grammar#34 was required for the tests.
Resolution: closed resolved
Reason: PR #401 was approved and merged into main as commit c2f0978a. The breaking update migrated the codebase and tests to Pydantic 2 after the required craft-grammar#34 support was merged.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Failing tests are due to craft-grammar needing this merge: https://github.com/canonical/craft-grammar/pull/34
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #401 as commit c2f0978a, migrating craft-application to Pydantic 2 across 23 files; craft-grammar#34 was required for the tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #401 as c2f0978a, upgrading craft-application to Pydantic 2 across 23 files (+531/-342); branch merge c3aae96c also landed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-application PR #401 as commit c2f0978a (plus branch merge c3aae96c), upgrading craft-application to pydantic 2 across 23 files (+531/-342). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-application PR #401 in commit c2f0978a to upgrade the codebase to Pydantic 2, updating 23 files (+531/-342). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to update the codebase to Pydantic 2. Approved by two reviewers and passed CI. The change modified 23 files (+531/-342). Initial test failures were resolved after the craft-grammar dependency received a corresponding update. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-grammar#34
(confidence 99%)
The PR body identifies #34 as a prerequisite for passing tests; it merged as commit 9ff908d.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #103 feat: upgrade to pydantic 2.x | craft-archives | merged | Merged PR #103 as commit b69f44a, upgrading craft-archives to Pydantic 2.x after three approvals; residual review feedback was moved to #118. | |
| #173 feat: upgrade to pydantic 2.x | craft-application | closed | Closed unmerged after the Pydantic 2 migration landed via craft-application#401 (c2f0978a); maintainer lengau credited #173 as helpful during that migration. | |
| #32 Make a pydantic 2 release of craft-grammar | craft-grammar | closed | Pydantic 2 support was delivered by merged PR canonical/craft-grammar#33, updating craft-grammar from Pydantic 1 to Pydantic 2. | |
| #451 build(deps): bump pydantic to v2 | craft-providers | merged | Merged PR #451 upgraded craft-providers to Pydantic v2 for 2.0; current project metadata requires pydantic~=2.4. | |
| #33 chore!: update to Pydantic 2 | craft-grammar | merged | Merged as commit 5e225fb via PR #33, updating craft-grammar to Pydantic 2 and revising grammar validation errors; fixes #32. | |
| #728 Migrate to Pydantic 2.x | craft-parts | closed | Pydantic 2 migration landed in canonical/craft-parts#771 via commit 6b155294, followed by cleanup in #778; craft-parts now requires pydantic>=2.0.0. | |
| #193 build(deps)!: update to pydantic 2 | craft-store | merged | Merged the breaking Pydantic 2 upgrade in #193 (commit 026b78d), updating dependencies and model code across 21 files (+135/-90). | |
| #60 Migrate to pydantic 2 | imagecraft | merged | PR #60 merged as commit be1741a, migrating Imagecraft to Pydantic V2 and newer craft libraries (FR-8917); pyproject now pins pydantic~=2.12.5. Approved by one reviewer with no unresolved comments. | |
| #4941 Migrate to Pydantic 2 | snapcraft | closed | Pydantic 2 migration completed in merged snapcraft#4955 via commit 1fc8fe6ab, resolving CRAFT-3159. | |
| #345 Migrate to Pydantic 2 | craft-application | closed | Pydantic 2 migration landed via merged PR #401, commit c2f0978a, updating 23 files and replacing the issue's Pydantic 1 requirements. |