← Back to issue list

build!: update to pydantic 2

View original Github issue

Metadata

Project
craft-application
Number
#401
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged to update the codebase to Pydantic 2. Approved by two reviewers and passed CI. The change modified 23 files (+531/-342). Initial test failures were resolved after the craft-grammar dependency received a corresponding update.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? ----- Failing tests are due to craft-grammar needing this merge: https://github.com/canonical/craft-grammar/pull/34

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to update the codebase to Pydantic 2. Approved by two reviewers and passed CI. The change modified 23 files (+531/-342). Initial test failures were resolved after the craft-grammar dependency received a corresponding update.
qwen3.6-35b-a3b-mtp-q6 Merged update to Pydantic 2. Failing tests were resolved by synchronizing with a required craft-grammar dependency update. Maintainer lengau integrated the build configuration change after dependency alignment.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#193 build(deps)!: update to pydantic 2 craft-store merged Merged to upgrade the project to pydantic 2. Approved by two reviewers, the update modified 21 files with 135 additions and 90 deletions.
86%
#32 Make a pydantic 2 release of craft-grammar craft-grammar closed Fixed by merging PR #33 into the feature/pydantic-2 branch, delivering the requested pydantic 2 release for craft-grammar.
81%
#60 Migrate to pydantic 2 imagecraft merged Merged after approval. The codebase was migrated to Pydantic V2 with updated craft libraries. Changes span 27 files (+278/-340 lines) and maintain 98% test coverage, resolving FR-8917.
80%
#33 chore!: update to Pydantic 2 craft-grammar merged Merged update to Pydantic 2. Resolves issue #32 by addressing breaking changes in grammar validation error messages. Approved by two reviewers, passed CI checks, and modified five files (+40/-41 lines).
80%
#601 feat: upgrade to pydantic 2.x craft-parts closed The pydantic 2.x upgrade for craft-parts was closed as superseded after addressing review feedback on validation error reporting. The changes were replaced by a newer update.
79%
#5173 build(deps): update pydantic etc. (main) snapcraft merged Merged automated dependency update upgrading pydantic to 2.10.3 and pydantic-core to 2.27.1. Approved by two reviewers, passed CI, and merged into main.
79%
#672 merge feature/pydantic-2 rockcraft merged Merged the pydantic 2 migration branch via rebase after two approvals and passing CI. The update modified 26 files, adding 3661 lines and removing 2150, finalizing the migration and dependency updates.
78%
#36 chore!: update to pydantic 2 craft-grammar merged Merged the Pydantic 2 migration across five files. Approved by two reviewers and passed CI. The maintainer manually verified the author's Canonical employment to override an automated CLA check failure before finalizing the merge.
78%
#103 feat: upgrade to pydantic 2.x craft-archives merged Merged the pydantic 2.x upgrade after passing CI and receiving three approvals. The maintainer moved the 13 unresolved review comments to a follow-up issue.
77%
#1777 feat(deps)!: switch to pydantic 2 charmcraft merged Merged pydantic 2 upgrade, incorporating #1776. Approved by two reviewers, the update modified 81 files with a net reduction of over 15,000 lines, completing the major version migration.
76%