feat: upgrade to pydantic 2.x
Metadata
Current evaluation
Merged PR #103 as commit b69f44a, upgrading craft-archives to Pydantic 2.x after three approvals; residual review feedback was moved to #118.
Resolution: closed resolved
Reason: The Pydantic 2.x upgrade was merged in commit b69f44a. A maintainer consolidated remaining review feedback into issue #118, but this follow-up did not prevent the requested upgrade from landing.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #103 as commit b69f44a, upgrading craft-archives to Pydantic 2.x after three approvals; residual review feedback was moved to #118. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #103 in commit b69f44a, upgrading craft-archives to Pydantic 2.x after three approvals. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #103, upgrading craft-archives to Pydantic 2.x after three approvals. Thirteen unresolved review comments were moved to follow-up issue #118. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged the pydantic 2.x upgrade after passing CI and receiving three approvals. The maintainer moved the 13 unresolved review comments to a follow-up issue. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-archives#118
(confidence 100%)
A maintainer explicitly moved the PR's remaining review comments into this follow-up issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #173 feat: upgrade to pydantic 2.x | craft-application | closed | Closed unmerged after the Pydantic 2 migration landed via craft-application#401 (c2f0978a); maintainer lengau credited #173 as helpful during that migration. | |
| #601 feat: upgrade to pydantic 2.x | craft-parts | closed | Closed unmerged as superseded after ~8 months stalled with 39 unresolved review comments. Pydantic 2 upgrade was later delivered by canonical/craft-parts#771 (commit 6b155294) plus #776, #778, #794. | |
| #401 build!: update to pydantic 2 | craft-application | merged | Merged PR #401 as commit c2f0978a, migrating craft-application to Pydantic 2 across 23 files; craft-grammar#34 was required for the tests. | |
| #794 chore: remove pydantic warnings | craft-parts | merged | Merged as commit 5c1c7dd3, incorporating craft-archives PR #122 (commit 00b9b3b) to eliminate Pydantic deprecation warnings. | |
| #451 build(deps): bump pydantic to v2 | craft-providers | merged | Merged PR #451 upgraded craft-providers to Pydantic v2 for 2.0; current project metadata requires pydantic~=2.4. | |
| #483 upgrade to pydantic 2.x | craft-providers | closed | PR #483 (a one-line pyproject.toml bump to pydantic>=2) was closed unmerged by its author as a duplicate; maintainers pointed to craft-providers#451, which landed as commit f380a9e and set pydantic~=2.4. | |
| #60 Migrate to pydantic 2 | imagecraft | merged | PR #60 merged as commit be1741a, migrating Imagecraft to Pydantic V2 and newer craft libraries (FR-8917); pyproject now pins pydantic~=2.12.5. Approved by one reviewer with no unresolved comments. | |
| #33 chore!: update to Pydantic 2 | craft-grammar | merged | Merged as commit 5e225fb via PR #33, updating craft-grammar to Pydantic 2 and revising grammar validation errors; fixes #32. | |
| #672 merge feature/pydantic-2 | rockcraft | merged | Merged feature/pydantic-2 into main, completing Rockcraft's Pydantic 2 migration and final dependency updates after two approvals. | |
| #32 Make a pydantic 2 release of craft-grammar | craft-grammar | closed | Pydantic 2 support was delivered by merged PR canonical/craft-grammar#33, updating craft-grammar from Pydantic 1 to Pydantic 2. |