← Back to issue list

feat: upgrade to pydantic 2.x

View original Github issue

Metadata

Project
craft-application
Number
#173
Type
pull request
State
closed
Author
linostar
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after the Pydantic 2 migration landed via craft-application#401 (c2f0978a); maintainer lengau credited #173 as helpful during that migration.

Resolution: closed superseded

Reason: craft-application#401 completed the same migration and merged as commit c2f0978a. Maintainer lengau closed #173 after confirming the latest craft-application already uses Pydantic 2.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Upgrade craft-application to use pydantic 2.x.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged after the Pydantic 2 migration landed via craft-application#401 (c2f0978a); maintainer lengau credited #173 as helpful during that migration.
stealth/space-bunny-alpha — closed superseded Pydantic 2 upgrade closed unmerged as superseded by craft-application#401 (commit c2f0978a); the maintainer credited this PR as helpful during that migration.
qwen/qwen3.6-35b-a3b — — Closed as superseded. The pydantic 2.x migration was already completed in the main branch, rendering this contribution obsolete. The maintainer acknowledged the changes were helpful for the actual upgrade.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#601 feat: upgrade to pydantic 2.x craft-parts closed Closed unmerged as superseded after ~8 months stalled with 39 unresolved review comments. Pydantic 2 upgrade was later delivered by canonical/craft-parts#771 (commit 6b155294) plus #776, #778, #794.
86%
#103 feat: upgrade to pydantic 2.x craft-archives merged Merged PR #103 as commit b69f44a, upgrading craft-archives to Pydantic 2.x after three approvals; residual review feedback was moved to #118.
84%
#401 build!: update to pydantic 2 craft-application merged Merged PR #401 as commit c2f0978a, migrating craft-application to Pydantic 2 across 23 files; craft-grammar#34 was required for the tests.
80%
#483 upgrade to pydantic 2.x craft-providers closed PR #483 (a one-line pyproject.toml bump to pydantic>=2) was closed unmerged by its author as a duplicate; maintainers pointed to craft-providers#451, which landed as commit f380a9e and set pydantic~=2.4.
80%
#451 build(deps): bump pydantic to v2 craft-providers merged Merged PR #451 upgraded craft-providers to Pydantic v2 for 2.0; current project metadata requires pydantic~=2.4.
75%
#728 Migrate to Pydantic 2.x craft-parts closed Pydantic 2 migration landed in canonical/craft-parts#771 via commit 6b155294, followed by cleanup in #778; craft-parts now requires pydantic>=2.0.0.
75%
#582 [EXPERIMENTAL] build(deps): use pydantic 2 craft-parts closed Closed unmerged in Aug 2024 by @lengau as superseded; the Pydantic 2 migration landed later via merged PR #771 (commit 6b155294) plus follow-ups #776, #778, #794, #811.
74%
#672 merge feature/pydantic-2 rockcraft merged Merged feature/pydantic-2 into main, completing Rockcraft's Pydantic 2 migration and final dependency updates after two approvals.
74%
#370 chore(deps): update dependency pydantic to v2 craft-providers closed Renovate pydantic v2 bump closed unmerged by mr-cal to defer migration to a larger craft effort; the upgrade later landed in merged PR #451 (commit f380a9e) for 2.0.
74%
#4941 Migrate to Pydantic 2 snapcraft closed Pydantic 2 migration completed in merged snapcraft#4955 via commit 1fc8fe6ab, resolving CRAFT-3159.
74%