← Back to issue list

chore!: update to Pydantic 2

View original Github issue

Metadata

Project
craft-grammar
Number
#33
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 5e225fb via PR #33, updating craft-grammar to Pydantic 2 and revising grammar validation errors; fixes #32.

Resolution: closed resolved

Reason: PR #33 was merged with two approvals and no unresolved comments, delivering the Pydantic 2 migration in commit 5e225fb and closing issue #32.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Most of the breaking changes are in the reported messages for grammar validation errors. Fixes #32 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 5e225fb via PR #33, updating craft-grammar to Pydantic 2 and revising grammar validation errors; fixes #32.
stealth/space-bunny-alpha — closed resolved Merged PR #33 updated craft-grammar to Pydantic 2, revising grammar validation error messages and fixing #32.
stealth/space-bunny-alpha — closed resolved Merged PR #33 updated craft-grammar to Pydantic 2, including revised grammar validation error messages; commit 5e225fb resolves issue #32.
qwen/qwen3.6-35b-a3b — — Merged update to Pydantic 2. Resolves issue #32 by addressing breaking changes in grammar validation error messages. Approved by two reviewers, passed CI checks, and modified five files (+40/-41 lines).

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: craft-grammar#32 (confidence 100%)

    PR #33 explicitly states that it fixes the request for a Pydantic 2 release.

Related issues

Issue Project State Summary Similarity
#36 chore!: update to pydantic 2 craft-grammar merged Merged PR #36 (commit 06fc994), completing the breaking Pydantic 2 update after two approvals and manual confirmation of the author's CLA employment status.
84%
#112 chore(deps): update to pydantic 2 & bump-pydantic craft-archives closed Closed unmerged; its Pydantic 2 migration was superseded by #103 (b69f44a) and merged into main through #123.
80%
#370 chore(deps): update dependency pydantic to v2 craft-providers closed Renovate pydantic v2 bump closed unmerged by mr-cal to defer migration to a larger craft effort; the upgrade later landed in merged PR #451 (commit f380a9e) for 2.0.
80%
#794 chore: remove pydantic warnings craft-parts merged Merged as commit 5c1c7dd3, incorporating craft-archives PR #122 (commit 00b9b3b) to eliminate Pydantic deprecation warnings.
79%
#771 chore: lift-and-shift update to pydantic 2 craft-parts merged Merged PR #771 as commit 6b155294, completing phase 1 of the Pydantic 2 migration across 38 files using bump-pydantic and follow-up fixes.
78%
#778 chore: pydantic 2 related cleanup craft-parts merged Merged Pydantic 2 cleanup across seven files in commit 68d61fa0, following prerequisite plugin-model restructuring in #775.
78%
#35 chore: fix pydantic deprecation craft-grammar merged Merged PR #35 (commit 6be0fc3) updated custom type validation to address Pydantic 2's deprecated __get_validators__ hook.
78%
#28 chore(deps): update dependency pydantic to v2 - autoclosed craft-grammar closed Renovate's Pydantic 2 bump was closed unmerged and superseded by dedicated migration PR #33, which landed in commit 5e225fb.
78%
#401 build!: update to pydantic 2 craft-application merged Merged PR #401 as commit c2f0978a, migrating craft-application to Pydantic 2 across 23 files; craft-grammar#34 was required for the tests.
78%
#1817 chore: merge pydantic 2 support to main charmcraft merged Pydantic 2 support was merged into main by PR #1817 (commit 394e6e55), completing the migration begun in #1777 across 52 files.
77%