← Back to issue list

chore!: update to Pydantic 2

View original Github issue

Metadata

Project
craft-grammar
Number
#33
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged update to Pydantic 2. Resolves issue #32 by addressing breaking changes in grammar validation error messages. Approved by two reviewers, passed CI checks, and modified five files (+40/-41 lines).

Suggested action:

No scores available.

Issue body

Most of the breaking changes are in the reported messages for grammar validation errors. Fixes #32 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged update to Pydantic 2. Resolves issue #32 by addressing breaking changes in grammar validation error messages. Approved by two reviewers, passed CI checks, and modified five files (+40/-41 lines).
qwen3.6-35b-a3b-mtp-q6 Merged upgrade to Pydantic 2, modifying grammar validation error messages. Resolves issue #32. Maintainer tigarmo completed the migration and validation checks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#36 chore!: update to pydantic 2 craft-grammar merged Merged the Pydantic 2 migration across five files. Approved by two reviewers and passed CI. The maintainer manually verified the author's Canonical employment to override an automated CLA check failure before finalizing the merge.
90%
#778 chore: pydantic 2 related cleanup craft-parts merged Merged a Pydantic 2 compatibility cleanup. Approved by two reviewers and passed CI. Modified seven files with 28 additions and 26 deletions. Required PR #775.
88%
#1817 chore: merge pydantic 2 support to main charmcraft merged Merged pydantic 2 support into the main branch after approval from two reviewers. The update modifies 52 files, adding 2860 lines and removing 714, completing the dependency upgrade.
86%
#207 chore(deps): drop Pydantic dependency craft-cli merged Merged changes remove the unused Pydantic dependency, resolving issue #201. Approved by two reviewers, passed CI checks, and reduced code by three lines across three files without impacting the 94.76% test coverage.
85%
#771 chore: lift-and-shift update to pydantic 2 craft-parts merged Merged after two approvals and passing CI. The update migrates the codebase to Pydantic 2 using bump-pydantic and manual fixes. It touched 38 files (+207/-127 lines) as the initial phase of the broader dependency upgrade.
84%
#4955 chore!: migrate to pydantic 2 snapcraft merged Merged after two approvals and passing CI. Migrates the codebase to Pydantic 2, resolving issue #4941. The author rebased and force-pushed clean commits prior to a rebase-merge.
84%
#794 chore: remove pydantic warnings craft-parts merged Successfully merged after approval by two reviewers and passing CI checks. The changes remove pydantic warnings across 9 files, adding 30 lines and deleting 16 to clean up framework deprecation notices.
83%
#408 chore!: merge pydantic 2 feature branch to main craft-application merged Merged the pydantic 2 feature branch into main, upgrading the codebase and resolving typing issues. Approved by two reviewers and passing CI checks, the merge introduces breaking changes required for the pydantic 2 dependency update.
83%
#112 chore(deps): update to pydantic 2 & bump-pydantic craft-archives closed The dependency update to Pydantic 2 was closed without merging. Lacking reviewer feedback, CI validation, and sustained activity, the pull request was abandoned.
82%
#122 chore: eliminate pydantic warnings craft-archives merged Merged after two approvals and passing CI. Refactored three files to eliminate pydantic deprecation warnings, adding 24 lines and removing 15.
82%