← Back to issue list

fix(test): minor test fixes

View original Github issue

Metadata

Project
craft-application
Number
#717
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #717 (commit 9f02b30f) switched spread tests to streaming output and adopted Spread's new reroot key, fixing #704 and #715.

Resolution: closed resolved

Reason: PR #717 merged as commit 9f02b30f. Its description explicitly links the changes to fixes for #704 and #715, and all reported CI checks passed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

1. Uses a stream rather than pausing the spread tests 2. Uses spread's new `reroot` key - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Fixes #704 CRAFT-4399 Fixes #715 CRAFT-4411

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #717 (commit 9f02b30f) switched spread tests to streaming output and adopted Spread's new reroot key, fixing #704 and #715.
stealth/space-bunny-alpha — closed resolved Merged PR #717 (9f02b30f) updated spread tests to stream output and use spread's new reroot key, addressing #704 and #715.
qwen/qwen3.6-35b-a3b — — Merged minor test fixes replacing spread test pausing with a stream approach and adopting the new reroot key. Resolves issues #704 and #715, plus CRAFT-4399 and CRAFT-4411. Approved by two reviewers with all CI checks passing.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#723 fix(testing): more intelligent test handling craft-application merged Merged PR #723 via commit 6b319b77, running Spread tests as root and strictly validating only top-level spread.yaml keys.
79%
#415 test: fix typo in spread extension fetch-service closed PR #415 was closed after approval was retracted; its typo fix was incorporated into merged PR #417 via commit 8363f15.
75%
#1366 tests(spread): make release test less flaky charmcraft merged Merged #1366 at commit 05b18a03, reducing flakiness in the Spread release test and resolving #1362.
75%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%.
74%
#2417 fix: fix a series of breaking spread tests charmcraft merged Merged PR #2417 at commit 3bee888e, fixing multiple spread-test failures and unblocking the core24 migration; three listed tests remained broken but non-blocking.
73%
#3662 tests: update spread url snapcraft merged Merged PR #3662 updated Spread tarball URLs in two test files via commit 507959d70.
73%
#2763 fix(tests/spread): fix reactive spread tests charmcraft merged Merged #2763 as 6e775f4a: split reactive spread coverage by legacy/Resolute, enabled binary wheels, and removed obsolete build flags.
73%
#5389 test(spread): trace logs in spread tests snapcraft merged Merged PR #5389 as ff6f5950e, adding trace logging to spread tests for better failure diagnostics.
73%
#926 test: address a couple of non-flaky spread failures rockcraft merged Merged PR #926 updated three spread-test configuration files to address persistent failures; all CI checks passed and two reviewers approved.
72%
#534 test(spread): workaround for flaky test fetch-service merged Merged PR #534 (commit 4f89bb7) worked around #533 by skipping the flaky snap names-query assertion while retaining the other spread-test checks.
72%