fix(test): minor test fixes
Metadata
Current evaluation
Merged minor test fixes replacing spread test pausing with a stream approach and adopting the new reroot key. Resolves issues #704 and #715, plus CRAFT-4399 and CRAFT-4411. Approved by two reviewers with all CI checks passing.
Suggested action: —
No scores available.
Issue body
1. Uses a stream rather than pausing the spread tests
2. Uses spread's new `reroot` key
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Fixes #704
CRAFT-4399
Fixes #715
CRAFT-4411
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged minor test fixes replacing spread test pausing with a stream approach and adopting the new reroot key. Resolves issues #704 and #715, plus CRAFT-4399 and CRAFT-4411. Approved by two reviewers with all CI checks passing. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged minor test fixes updating spread tests to use streams instead of pausing and adopting the new reroot key. Resolves issues #704 and #715. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1381 fix: fix most spread tests on craft-application | charmcraft | merged | Merged updates fixing most spread tests for craft-application. Two smoketests remain broken. Approved despite minor linting and unit test failures. Resolves CRAFT-2239. | |
| #102 test: update craftctl test | snapcraft-rocks | merged | Merged after two approvals and passing CI checks. Updates the spread test to validate the fix for snapcraft-rocks#33, modifying one file with seven added lines. | |
| #1325 test(spread): consolidate basic init/build tests | charmcraft | merged | Merged after approval by two reviewers. Consolidates basic init and build spread tests across four files, reducing 80 lines and adding 28. Resolves CRAFT-2127. | |
| #386 tests: update testing to use craft-test | fetch-service | merged | Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines). | |
| #1386 fix: final spread test fixes for craft-application | charmcraft | merged | Merged after approval by two reviewers. Resolves final spread test issues for craft-application across seven files, removing 127 lines and adding 104. Changes integrated into the main branch. | |
| #1287 fix(tests): fixes bundle spread test | charmcraft | merged | Merged. Resolves issue #1262 and CRAFT-2052 by fixing the bundle spread test. Replaced a failing charm path check with Python-based YAML validation. Approved by two reviewers, passed CI, and successfully executed the large spread test. | |
| #29 tests: use the Craft CLI lib fixtures | rockcraft | merged | Merged updates to replace test fixtures with the Craft CLI library version. Approved by one reviewer, modifying five files (+11/-54 lines). Resolves CRAFT-996. | |
| #56 Add a fuller integration test, and multiple minor changes to support it | craft-archives | merged | Merged. Added a comprehensive integration test for repo.install() with minor supporting changes across seven files. Approved, passed CI, and achieved 100% diff coverage. Resolves CRAFT-1649 and CRAFT-1682. | |
| #16 tests: add spread support | rockcraft | merged | Merged after approval and passing CI, adding spread support to tests per CRAFT-865. | |
| #723 fix(testing): more intelligent test handling | craft-application | merged | Merged after approval. Updates test handling to run spread tests as root and strictly parse top-level spread.yaml keys. Approved by two reviewers and passed CI checks before integration. |