← Back to issue list

test(spread): trace logs in spread tests

View original Github issue

Metadata

Project
snapcraft
Number
#5389
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after approval. Added trace logging to spread tests. Despite CI failures from extra snapcraft output, the change was approved and merged following a related feature branch integration to prevent conflicts.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval. Added trace logging to spread tests. Despite CI failures from extra snapcraft output, the change was approved and merged following a related feature branch integration to prevent conflicts.
qwen/qwen3.6-35b-a3b Added trace logs to spread tests. Initial CI failures were attributed to extra output. Merging was deferred to coordinate with a concurrent branch merge to main. The PR was ultimately merged after review.
qwen3.6-35b-a3b-mtp-q6 Merged after adding trace logs to spread tests. Review was paused to align with the feature/snapcraft-test branch merge to main, preventing a large conflict. Changes were successfully integrated.
qwen3.6-35b-a3b-mtp-q6 Merged after being deferred to avoid conflicts with the feature/snapcraft-test branch landing on main. Adds trace log output to spread tests to improve debugging visibility.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5845 test(spread): test building base and snapd snaps snapcraft merged Merged spread tests for building base and snapd snaps. Despite initial CI failures linked to snapcraft issue #5843, the changes were approved and integrated to maintain build compatibility with mainline snapcraft.
79%
#2793 tests: enable SNAPCRAFT_BUILD_INFO for spread snapcraft merged Merged following approval and passing CI. Enabled SNAPCRAFT_BUILD_INFO for spread tests to cover manifest changes. Included a fix for the nil-basic spread test. Minimal diff across three files.
78%
#16 tests: add spread support rockcraft merged Merged after approval and passing CI, adding spread support to tests per CRAFT-865.
77%
#1272 tests: initial setup for the snapcraft snap tests with spread snapcraft merged Merged to master following single reviewer approval. Introduced initial spread test infrastructure for snapcraft across four files (+39 lines). Code coverage remained stable at 95.33%.
76%
#1084 tests: check for submodules before running spread charmcraft merged Merged changes verifying the snapd-testing-tools submodule before running Spread tests. Adds a clear error if missing. Approved by a reviewer, passed CI, and merged with minimal modifications.
75%
#1029 fix(testing): error early if spread.yaml is invalid. craft-application merged Merged after two approvals. Adds early validation to fail tests immediately if spread.yaml is invalid. CI passed except for an unrelated snap-test failure, which was overridden.
74%
#240 tests: check for submodules before running spread rockcraft merged Merged. Adds a pre-check for the snapd-testing-tools submodule before running spread tests, providing a clear error if missing. Approved by two reviewers, passed CI, and merged successfully.
74%
#1385 test: show exception tracebacks in spread tests charmcraft merged Merged a one-line change enabling exception tracebacks in spread tests. Approved by a reviewer and integrated into the codebase with zero unresolved comments.
74%
#4105 tests: check for submodules before running spread snapcraft merged Merged. Adds a pre-run check for the snapd-testing-tools submodule in spread tests to provide a clear error if missing. Approved by two reviewers, passed CI, and introduced no coverage changes.
73%
#4433 tests(spread): add remote-build spread test snapcraft merged Merged changes adding spread tests for new and legacy remote-build, resolving issue #4398. Approved by two reviewers with passing CI checks.
73%