← Back to issue list

feat: bash auto-completion generation

View original Github issue

Metadata

Project
craft-cli
Number
#319
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged the bash auto-completion generation feature. Approved by two reviewers, passed CI and tox, and closed issue #211. The change adds approximately 758 lines across 15 files to implement automatic shell completion generation.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? Closes #211. CRAFT-3854

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the bash auto-completion generation feature. Approved by two reviewers, passed CI and tox, and closed issue #211. The change adds approximately 758 lines across 15 files to implement automatic shell completion generation.
qwen3.6-35b-a3b-mtp-q6 Merged bash auto-completion generation, resolving #211 and CRAFT-3854. Author verified unrelated linting errors and confirmed Snapcraft branch compatibility prior to merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5218 feat: add improved bash completion script snapcraft merged Merged the improved bash completion script after three approvals and passing CI checks. The update modifies seven files, reducing 47 lines to 21. Reviewers validated the changes and recommended future implementation of part name autocompletion.
84%
#793 feat: add improved bash completion script rockcraft merged Merged after approval by two reviewers and passing CI checks. Adds an improved bash tab-completion script, modifying four files to address CRAFT-3875.
77%
#86 feat: add bash completion script imagecraft merged Merged the bash completion script. Author rebased on main per reviewer request. Manual testing replaced automated spread tests due to complexity, with a known limitation tracked separately.
76%
#2111 feat: add improved bash completion script charmcraft merged Merged an improved bash completion script replacing the legacy version. Approved by two reviewers, the update adds 34 lines and removes 195 across six files. Resolves CRAFT-3874.
76%
#453 Add in bash completion snapcraft merged Merged bash completion feature. Author addressed reviewer feedback by logging a related bug and updating the commit message per guidelines. After admin verification and final testing, the changes were approved and merged.
74%
#5208 feat: auto-generate bash completion snapcraft closed Closed and superseded by PR #5218. The branch was intended only as a showcase and was not merged.
73%
#1390 meta: bash completion support snapcraft merged Merged after adding bash completion support for snapcraft. Approved by two reviewers with passing CI checks. The change modifies five files, adding 72 lines and removing 2.
72%
#222 Modernize the Bash completion definition. charmcraft merged Merged updates to modernize the Bash completion definition. Approved by two reviewers, the change modifies one file (+22/-4 lines). The author noted the inability to test for missing command additions.
71%