feat: add bash completion script
Metadata
Current evaluation
Merged into main as f568b9a, adding Bash completion generation for imagecraft via craft-cli; CRAFT-3878.
Resolution: closed resolved
Reason: PR #86 was merged after two approvals. Commit f568b9a added completion generation using canonical/craft-cli#319, which landed in craft-cli as 4d41d7d.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
---
CRAFT-3878
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into main as f568b9a, adding Bash completion generation for imagecraft via craft-cli; CRAFT-3878. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into imagecraft as f568b9a, adding a Bash completion script for CRAFT-3878; global-argument completion remains tracked as CRAFT-4007. | |
| stealth/space-bunny-alpha | — | closed resolved | PR imagecraft#86 (commit f568b9a) merged, adding Bash tab-completion: a get_app_info() helper in imagecraft/cli.py plus completion.sh generation in snap/snapcraft.yaml. Ticket CRAFT-3878. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-cli#319 added automatic Bash completion generation, completing CRAFT-3878 after two approvals and successful CI/tox runs. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged the bash completion script. Author rebased on main per reviewer request. Manual testing replaced automated spread tests due to complexity, with a known limitation tracked separately. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after author rebased to clean git history. Bash completion script added without automated spread tests, as manual testing was deemed sufficient. A known limitation with global argument completion is tracked separately. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-cli#319
(confidence 96%)
Added the automatic Bash completion generator used by Imagecraft; merged as 4d41d7d.
-
Related To:
canonical/craft-cli#211
(confidence 90%)
Tracked the underlying Bash completion generation delivered by canonical/craft-cli#319.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2111 feat: add improved bash completion script | charmcraft | merged | Merged charmcraft#2111 in commit d5a4b704, replacing Charmcraft’s legacy Bash completion with an improved script generated through craft-cli completion tooling. | |
| #319 feat: bash auto-completion generation | craft-cli | merged | Merged feature adding generated Bash auto-completion; it closes canonical/craft-cli#211 via commit 4d41d7d. | |
| #5218 feat: add improved bash completion script | snapcraft | merged | Merged in #5218 (commit 387202653), replacing the manually maintained Bash completion with a dynamically generated script that tracks current commands and options; shipped in Snapcraft 8.7. | |
| #453 Add in bash completion | snapcraft | merged | Merged PR #453 via commit 6ea95fd50, adding a simple Bash completion script for Snapcraft commands. | |
| #793 feat: add improved bash completion script | rockcraft | merged | Merged PR #793 as commit 380dd3c1, adding improved Bash tab completion for commands and options; documented in the Rockcraft 1.8 release notes. | |
| #211 Generate bash completion for the application | craft-cli | closed | Bash completion generation was implemented and released in craft-cli 2.14.0 by merged PR canonical/craft-cli#319 (commit 4d41d7d). | |
| #1390 meta: bash completion support | snapcraft | merged | Merged PR #1390 added bash completion support for snapcraft and snapcraft metadata, landing as commit 2d01bc112. |