← Back to issue list

style(ruff): disable PLW1641

View original Github issue

Metadata

Project
starbase
Number
#409
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after two approvals and passing CI checks. Disables the Ruff PLW1641 (eq-without-hash) lint rule via a single configuration change. Related lint fixes were handled in PRs #410 and #411.

Suggested action:

No scores available.

Issue body

https://docs.astral.sh/ruff/rules/eq-without-hash/ - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two approvals and passing CI checks. Disables the Ruff PLW1641 (eq-without-hash) lint rule via a single configuration change. Related lint fixes were handled in PRs #410 and #411.
qwen3.6-35b-a3b-mtp-q6 Merged the change to disable the Ruff PLW1641 lint rule. Related lint fixes were addressed in separate pull requests #410 and #411.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#582 style: ruff 0.16 starbase merged Merged following two approvals and successful CI checks. Updates ruff to 0.16 and adds a configuration to ignore the PLR0917 rule for tests.
82%
#907 style: adjust linting rules for ruff 0.12 rockcraft merged Merged adjustments to Ruff 0.12 linting rules, removing the noqa directive for PLC0415 since it is frequently used in Rockcraft. Approved by two reviewers, passed CI checks, and updated one file with three added lines.
77%
#351 linters: add PLR2004 to ruff ignore craft-parts merged Merged adding PLR2004 to the ruff ignore list to suppress false positives for magic value comparisons in tests. Approved, passed CI, and updated the configuration file with one line.
74%
#90 lint: ignore ruff SIM117 starbase merged Merged changes to ignore the ruff SIM117 lint rule, which reduces readability with 88-character line lengths. Approved by a reviewer, passed CI, and updated the lint configuration.
74%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged following two approvals and passing CI checks. Resolves lint compatibility for ruff 0.12 while preserving backwards compatibility with ruff 0.11. Applied via a minimal two-line adjustment.
74%
#55 lint: stricter ruff rules starbase merged Merged stricter ruff linting rules. The change modifies one file with 23 additions and 9 deletions, enforces stricter configuration, and received reviewer approval before integration.
73%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
73%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged after approval by three reviewers. Resolves linting errors from a ruff update, modifying three files with a +7/-7 line change. Successfully integrated into the codebase.
73%
#4981 style(lint): fix ruff 0.6 linting errors snapcraft merged Merged after receiving two approvals and passing CI checks. Resolves ruff 0.6 linting errors with a minimal one-file change.
72%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged after approval by two reviewers. Resolves linting failures introduced by ruff 0.12 across 14 files. CI passed for fast tests, linting, and security scans, while slow test failures were tracked separately in #804.
72%