← Back to issue list

sources: copy mutable ignore pattern for source handlers (CRAFT-494)

View original Github issue

Metadata

Project
craft-parts
Number
#120
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged to resolve CRAFT-494. Source handlers now instantiate independent copies of mutable ignore patterns, preventing unintended shared state modification. Approved by two reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

Source handlers may modify the list of ignore patterns, so make a new copy for each source handler instance. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to resolve CRAFT-494. Source handlers now instantiate independent copies of mutable ignore patterns, preventing unintended shared state modification. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that creates a copy of mutable ignore patterns for each source handler instance, preventing unintended modifications. Resolves CRAFT-494.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#96 many: fix source ignore patterns (CRAFT-375) craft-parts merged Merged fix for source ignore patterns preventing locally generated files from being pulled as sources. Updates allow custom ignore patterns for outputs and correctly ignore work directories. Approved by two reviewers with passing CI checks.
72%