sources: fix ignore patterns in local sources
Metadata
Current evaluation
Merged PR #363, preventing local-source processing from accumulating repeated ignore patterns; the fix landed as 722d8f57 and was later backported by #373.
Resolution: closed resolved
Reason: PR #363 was approved with no unresolved comments and merged. Commit 722d8f57 prevents cumulative local-source ignore patterns; PR #373 (ec0ab362) backported the fix to the 1.18 branch.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Don't create a cumulative list of patterns to ignore when processing local sources, or the list can become quite large with repetitions of the same patterns.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #363, preventing local-source processing from accumulating repeated ignore patterns; the fix landed as 722d8f57 and was later backported by #373. | |
| stealth/space-bunny-alpha | — | closed resolved | Maintainer cmatsuoka's PR #363 was merged as commit 722d8f57, stopping LocalSource from cumulatively appending duplicate ignore patterns (parts/stage/prime/overlay, partition, work dir) and keeping per-pull ignore lists small. Backported to 1.18 via PR #373 (ec0ab362). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-parts#362 as 722d8f57, fixing local-source ignores without accumulating repeated patterns; #373 (ec0ab362) backported the fix to the 1.18 branch. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for local source ignore patterns that prevented cumulative list creation, eliminating repetitions and excessive size. Approved by reviewer, passed CI, and modified 2 files (+21/-6). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix preventing cumulative ignore pattern accumulation in local sources. Previously, repeated patterns caused list bloat. The update optimizes processing by avoiding duplicate entries during local source handling. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#373
(confidence 98%)
Backported the local-source ignore-pattern fix to the 1.18 branch in ec0ab362.
-
Likely Fixed By:
canonical/craft-parts#362
(confidence 95%)
The linked resolution identifies #362 as carrying the fix in commit 722d8f57.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #362 sources: fix ignore patterns in local sources | craft-parts | merged | Merged as 722d8f57; local sources no longer accumulate repeated ignore patterns. Backported to 1.18 by #373 (ec0ab362). | |
| #373 sources: fix ignore patterns in local sources | craft-parts | merged | Merged backport PR #373 (commit ec0ab362) porting #362 to the 1.18 branch: local sources no longer accumulate a growing, repetitive ignore-pattern list. | |
| #96 many: fix source ignore patterns (CRAFT-375) | craft-parts | merged | Merged #96 via commit 9fd6ee7c (merge ab69ef78), fixing local-source filtering to exclude generated outputs, support app-defined ignore patterns, and honor custom work directories. | |
| #375 Release 1.18.1 | craft-parts | merged | Merged release PR #375 as commit 7d99fbe6, publishing v1.18.1 with the local-source ignore-pattern fix backported by #373. | |
| #369 Release 1.15.3 | craft-parts | merged | Merged as release 1.15.3, backporting the local-source ignore-pattern fix from #362 to the 1.15 maintenance line. | |
| #120 sources: copy mutable ignore pattern for source handlers (CRAFT-494) | craft-parts | merged | Merged PR #120 (CRAFT-494, cmatsuoka) fixed shared mutable ignore patterns: merge commit 880735ee, implementation commit 280e1592, approved by 2 reviewers with no unresolved comments. | |
| #376 Merge/1.18.1 | craft-parts | merged | PR #376 merged (commit 074d654f) backporting release 1.18.1 to main, including the local-source ignore-pattern fix; hotfix-only pinned linters were intentionally left out. |