many: fix source ignore patterns (CRAFT-375)
Metadata
Current evaluation
Merged fix for source ignore patterns preventing locally generated files from being pulled as sources. Updates allow custom ignore patterns for outputs and correctly ignore work directories. Approved by two reviewers with passing CI checks.
Suggested action: —
No scores available.
Issue body
Work directories and files generated by the application in the current
directory (which may be a local source for plugins) should be ignored when
pulling sources. This change fixes a number of issues related to file
patterns to ignore:
- Don't pull local sources matching the patterns to ignore, otherwise the
newly generated application file may be also considered a source file.
- Allow the application to configure ignore patterns to match files it
generated (such as `*.snap` for snapcraft, or `*.charm` for charmcraft).
- When a work directory is set, ignore it instead of the standard parts,
prime, stage directories.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for source ignore patterns preventing locally generated files from being pulled as sources. Updates allow custom ignore patterns for outputs and correctly ignore work directories. Approved by two reviewers with passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for source ignore patterns. Updated logic to exclude local sources matching ignore patterns, allow custom patterns for generated files, and prioritize ignoring the work directory over standard directories. Resolves CRAFT-375. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #362 sources: fix ignore patterns in local sources | craft-parts | merged | Merged fix for local source ignore patterns. Prevents cumulative list buildup and repetitions. Approved by one reviewer, passed CI, and committed with 21 additions and 6 deletions across two files. | |
| #363 sources: fix ignore patterns in local sources | craft-parts | merged | Merged fix for local source ignore patterns that prevented cumulative list creation, eliminating repetitions and excessive size. Approved by reviewer, passed CI, and modified 2 files (+21/-6). | |
| #373 sources: fix ignore patterns in local sources | craft-parts | merged | Merged fix for local source ignore patterns to prevent cumulative and repetitive lists. This backport of #362 to the 1.18 branch optimizes pattern processing, received approval, and passed CI checks. | |
| #375 Release 1.18.1 | craft-parts | merged | Merged release 1.18.1, fixing ignore patterns in local sources. Approved by two reviewers and passed CI checks before integration. | |
| #322 sources: improve missing local source error message | craft-parts | merged | Merged. Updates error handling to display a clear source not found message instead of a file copy error when a local source is missing. Approved by two reviewers, passed CI, and changed 17 lines across two files. | |
| #369 Release 1.15.3 | craft-parts | merged | Merged release 1.15.3, backporting a fix for local sources ignore patterns. Approved by one reviewer, passed CI checks, and updated five files. | |
| #5795 fix: properly ignore source-code field in metadata linter | snapcraft | merged | Merged to resolve issue #5794 by properly ignoring the source-code field in the metadata linter. Approved by two reviewers, passed all CI checks, and verified working. | |
| #172 executor: use source type specified in part (CRAFT-831) | craft-parts | merged | Merged fix for #171 that prioritizes user-specified source types over URI inference during package builds. Approved by one reviewer, passed CI, and modified two files. | |
| #120 sources: copy mutable ignore pattern for source handlers (CRAFT-494) | craft-parts | merged | Merged to resolve CRAFT-494. Source handlers now instantiate independent copies of mutable ignore patterns, preventing unintended shared state modification. Approved by two reviewers and passed CI checks. | |
| #191 requirements: update craft-parts to 1.18.1 | rockcraft | merged | Merged update to craft-parts 1.18.1, fixing ignored file patterns during local source processing. Approved by two reviewers with passing CI checks. Modified three files. |