many: fix source ignore patterns (CRAFT-375)
Metadata
Current evaluation
Merged #96 via commit 9fd6ee7c (merge ab69ef78), fixing local-source filtering to exclude generated outputs, support app-defined ignore patterns, and honor custom work directories.
Resolution: closed resolved
Reason: PR #96 was approved and merged as ab69ef78, with implementation commit 9fd6ee7c. It resolves CRAFT-375 by correcting source ignore-pattern handling.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Work directories and files generated by the application in the current
directory (which may be a local source for plugins) should be ignored when
pulling sources. This change fixes a number of issues related to file
patterns to ignore:
- Don't pull local sources matching the patterns to ignore, otherwise the
newly generated application file may be also considered a source file.
- Allow the application to configure ignore patterns to match files it
generated (such as `*.snap` for snapcraft, or `*.charm` for charmcraft).
- When a work directory is set, ignore it instead of the standard parts,
prime, stage directories.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #96 via commit 9fd6ee7c (merge ab69ef78), fixing local-source filtering to exclude generated outputs, support app-defined ignore patterns, and honor custom work directories. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-parts#96 via ab69ef78 (9fd6ee7c), fixing source ignore patterns for work directories and generated output files. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for source ignore patterns preventing locally generated files from being pulled as sources. Updates allow custom ignore patterns for outputs and correctly ignore work directories. Approved by two reviewers with passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for source ignore patterns. Updated logic to exclude local sources matching ignore patterns, allow custom patterns for generated files, and prioritize ignoring the work directory over standard directories. Resolves CRAFT-375. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #363 sources: fix ignore patterns in local sources | craft-parts | merged | Merged PR #363, preventing local-source processing from accumulating repeated ignore patterns; the fix landed as 722d8f57 and was later backported by #373. | |
| #362 sources: fix ignore patterns in local sources | craft-parts | merged | Merged as 722d8f57; local sources no longer accumulate repeated ignore patterns. Backported to 1.18 by #373 (ec0ab362). | |
| #373 sources: fix ignore patterns in local sources | craft-parts | merged | Merged backport PR #373 (commit ec0ab362) porting #362 to the 1.18 branch: local sources no longer accumulate a growing, repetitive ignore-pattern list. | |
| #120 sources: copy mutable ignore pattern for source handlers (CRAFT-494) | craft-parts | merged | Merged PR #120 (CRAFT-494, cmatsuoka) fixed shared mutable ignore patterns: merge commit 880735ee, implementation commit 280e1592, approved by 2 reviewers with no unresolved comments. |